Repository navigation
Rewrite Call Subject to Kotlin + Compose - #111
Merged
Merged
Conversation
sdsantos
commented
Oct 22, 2026
sdsantos
commented
 |
 |
RankoR
suggested changes
Oct 22, 2026
| ) { | ||
| OutlinedTextField( | ||
| value = subject, | ||
| onValueChange = { onSubjectChange(it.limit(subjectLimit, subjectEncoding)) }, |
Member
There was a problem hiding this comment.
When your string has max allowed length, inserting at the beginning, it will remove from the end; Also, if you have 15 ASCII characters and insert one unicode character, it will cut it, producing malformed unicode.
Member
There was a problem hiding this comment.
Not sure if we need to fix the first one, but the second looks quite important.
Author
There was a problem hiding this comment.
Regarding the first one, I don't think it's important, specially for this feature. But it's a detail that happens in limited text fields like the Group name for example. If we do address it, we should have an implementation that works across the board for all those text fields.
RankoR
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.