Feature/jcode integration - #2578
Conversation
RED: tests/test_jcode.py fails because jcode install and jcode-hook are not implemented. AI-assisted: Jcode
Install the Graphify skill under ~/.jcode, safely merge the Jcode pre_tool hook, and redirect the first raw code lookup per session to graphify query. GREEN: 213 focused and adjacent tests pass; isolated installer/hook acceptance workflow passes. AI-assisted: Jcode
![graphify-labs[bot]](https://avatars.githubusercontent.com/in/4356270?s=60&v=4){kind=small}
There was a problem hiding this comment.
Graphify reviewed this change.
Worth a look — the grounded gate found no coupling regressions or blocking issues, but 1 advisory finding(s) below merit a look before merge.
Graphify review — findings
This PR adds support for a new "Jcode" platform in the graphify install/uninstall tooling. It registers a Jcode Agent Skill, wires up a jcode-hook pre-tool guard (invoked via a new CLI command) that redirects raw search/read tool calls toward graphify query, and adds config.toml manipulation helpers to insert/remove the hook from Jcode's hooks.pre_tool setting. It also updates the README, CLI usage text, __main__ imports, uninstall-all cleanup, and a .gitattributes merge driver entry for graph.json. The surface area spans graphify/install.py (platform config, hook install/uninstall, TOML editing helpers), graphify/cli.py (hook guard logic and command dispatch), graphify/__main__.py (imports and usage), plus documentation and gitattributes.
Worth a look
- jcode-hook guard blocks 'read' tool without checking target is indexed —
graphify/cli.py· Escalate · medium- agreed by 2 of 2 members but NOT verified (no proof, no reproducing execution) — consensus is not a verdict; needs human review
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 488 functions depend on the 237 functions this change touches.
Health — this change adds coupling hotspots:
- worse:
dispatch_command()— 2 callers, 118 callees - worse:
dispatch_install_cli()— 2 callers, 32 callees - worse:
install()— 5 callers, 12 callees - worse:
uninstall_all()— 2 callers, 14 callees
Verification — 488 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 488 function(s) in the blast radius were not formally verified this run
· 4 more finding(s) on lines outside this diff (see the check run).
1 participant
No description provided.