-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add fill tool support on strokes #4032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seam0s-dev
wants to merge
18
commits into
GraphiteEditor:master
Choose a base branch
from
seam0s-dev:2615-fill-tool-on-strokes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d1612e7
Implement fill tool on strokes
seam0s-dev b1d47b8
Testing out transforms on the overlay strokes
seam0s-dev c5f2a4f
Fixed transforms on overlay strokes using stroke transform
seam0s-dev 95e6a92
Refactor and add overlay support based on paint order
seam0s-dev 2adac3b
Add stroke align support on fill overlays
seam0s-dev f412eb9
Fix overlay pattern scaling and ignore StrokeAlign on open subpaths
seam0s-dev feb6895
Add StrokeAlign and PaintOrder support on stroke detection
seam0s-dev e92f543
Merge remote-tracking branch 'origin/master' into 2615-fill-tool-on-s…
seam0s-dev 3754701
Merge branch 'master' into 2615-fill-tool-on-strokes
seam0s-dev 7a9cf59
Implement stroke and fill overlays for desktop
seam0s-dev a8b0bae
Fix stroke artifacts
seam0s-dev 966c160
Merge remote-tracking branch 'origin/master' into 2615-fill-tool-on-s…
seam0s-dev 8ab03cc
Improve stroke detection and refactor
seam0s-dev 9173e22
Fix stroke detection on open subpaths with StrokeAlign::Inside
seam0s-dev 855fb9d
Merge remote-tracking branch 'origin/master' into 2615-fill-tool-on-s…
seam0s-dev 129486f
Fix stroke_color_set
seam0s-dev e431d69
Fix regression
seam0s-dev c5bec01
Try fix regression
seam0s-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Pivot and Origin overlay checkboxes are bound to the wrong visibility fields, so the checked state and toggle action are inverted.
Prompt for AI agents