-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement pressure-sensitive drawing with pen tablets on web #4083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oluseyi
wants to merge
11
commits into
GraphiteEditor:master
Choose a base branch
from
oluseyi:pen-pressure
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
95a33b5
Rename mouse-related structures to reference "pointer" instead
oluseyi 34a79cf
Persist pen pressure in PointerState, EditorPointerState
oluseyi 486c46c
Capture PointerEvent attributes from editor
oluseyi 6ab5e10
Capture pen pressure along user brush path and feed into blit point g…
oluseyi 1f390a8
Implement pressure-sensitive blitting, modifying stamp pixel alpha
oluseyi de54699
Guard against zero-length input delta and respect spacing parameter w…
oluseyi 0d8c477
Address code review feedback
oluseyi 6db1eb4
Merge branch 'master' into pen-pressure
oluseyi 5286abe
CI: rust_fmt
oluseyi 1b518c8
CI: fix tests
oluseyi eca8fc3
Merge branch 'master' into pen-pressure
oluseyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| pub mod input_keyboard; | ||
| pub mod input_mouse; | ||
| pub mod input_pointer; | ||
| pub mod macros; | ||
| pub mod misc; |
14 changes: 7 additions & 7 deletions
14
editor/src/messages/input_preprocessor/input_preprocessor_message.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,17 @@ | ||
| use crate::messages::input_mapper::utility_types::input_keyboard::{Key, ModifierKeys}; | ||
| use crate::messages::input_mapper::utility_types::input_mouse::EditorMouseState; | ||
| use crate::messages::input_mapper::utility_types::input_pointer::EditorPointerState; | ||
| use crate::messages::prelude::*; | ||
|
|
||
| #[impl_message(Message, InputPreprocessor)] | ||
| #[derive(PartialEq, Clone, Debug, serde::Serialize, serde::Deserialize)] | ||
| pub enum InputPreprocessorMessage { | ||
| DoubleClick { editor_mouse_state: EditorMouseState, modifier_keys: ModifierKeys }, | ||
| DoubleClick { editor_pointer_state: EditorPointerState, modifier_keys: ModifierKeys }, | ||
| KeyDown { key: Key, key_repeat: bool, modifier_keys: ModifierKeys }, | ||
| KeyUp { key: Key, key_repeat: bool, modifier_keys: ModifierKeys }, | ||
| PointerDown { editor_mouse_state: EditorMouseState, modifier_keys: ModifierKeys }, | ||
| PointerMove { editor_mouse_state: EditorMouseState, modifier_keys: ModifierKeys }, | ||
| PointerUp { editor_mouse_state: EditorMouseState, modifier_keys: ModifierKeys }, | ||
| PointerShake { editor_mouse_state: EditorMouseState, modifier_keys: ModifierKeys }, | ||
| PointerDown { editor_pointer_state: EditorPointerState, modifier_keys: ModifierKeys }, | ||
| PointerMove { editor_pointer_state: EditorPointerState, modifier_keys: ModifierKeys }, | ||
| PointerUp { editor_pointer_state: EditorPointerState, modifier_keys: ModifierKeys }, | ||
| PointerShake { editor_pointer_state: EditorPointerState, modifier_keys: ModifierKeys }, | ||
| CurrentTime { timestamp: u64 }, | ||
| WheelScroll { editor_mouse_state: EditorMouseState, modifier_keys: ModifierKeys }, | ||
| WheelScroll { editor_pointer_state: EditorPointerState, modifier_keys: ModifierKeys }, | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.