chore: add microservice architecture scaffolding#16
Closed
Patel230 wants to merge 6 commits into
Closed
Conversation
Add Dockerfile, .dockerignore, .env.example, api/openapi.yaml, deploy/docker/docker-compose.yml, docs/architecture.md, and .github/workflows/docker.yml for GHCR build+push CI.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v3 |
|
|
||
| - name: Log in to GHCR | ||
| if: github.event_name != 'pull_request' | ||
| uses: docker/login-action@v3 |
|
|
||
| - name: Docker metadata | ||
| id: meta | ||
| uses: docker/metadata-action@v5 |
| type=sha,prefix=sha- | ||
|
|
||
| - name: Build and push | ||
| uses: docker/build-push-action@v6 |
The previous merge-commit build failed due to stale module cache. This forces a clean rebuild with current go.mod state.
The Dockerfile was copying go.mod first, running go mod download, then copying source. This meant the local perf/ package wasn't available during go mod download. Copy everything first.
.dockerignore was excluding the perf/ directory which is a local Go package required by cmd/trace.
Add explicit storer Close() via t.Cleanup to release git pack file descriptors before t.TempDir() removes the directory. Also disable git auto-GC in test repos to prevent background goroutines from holding files open during cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary