Remove references to resource location constructor, use static methods instead - #5236
Open
gustovafing wants to merge 10 commits into
Open
Remove references to resource location constructor, use static methods instead#5236gustovafing wants to merge 10 commits into
gustovafing wants to merge 10 commits into
Conversation
screret
suggested changes
Aug 4, 2026
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
…java Co-authored-by: screret <68943070+screret@users.noreply.github.com>
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
screret
suggested changes
Aug 4, 2026
screret
left a comment
screret
left a comment
Contributor
There was a problem hiding this comment.
spotted a few more things, sorgy
Comment on lines
+352
to
353
| ResourceLocation lootTableId = ResourceLocation.fromNamespaceAndPath(blockEntry.getId().getNamespace(), | ||
| "blocks/" + blockEntry.getId().getPath()); |
Contributor
There was a problem hiding this comment.
Suggested change
| ResourceLocation lootTableId = ResourceLocation.fromNamespaceAndPath(blockEntry.getId().getNamespace(), | |
| "blocks/" + blockEntry.getId().getPath()); | |
| ResourceLocation lootTableId = blockEntry.getId().withPrefix("blocks/"); |
Comment on lines
+341
to
+342
| ResourceLocation lootTableId = ResourceLocation.fromNamespaceAndPath(id.getNamespace(), | ||
| "blocks/" + id.getPath()); |
Contributor
There was a problem hiding this comment.
Suggested change
| ResourceLocation lootTableId = ResourceLocation.fromNamespaceAndPath(id.getNamespace(), | |
| "blocks/" + id.getPath()); | |
| ResourceLocation lootTableId = blockEntry.getId().withPrefix("blocks/"); |
Comment on lines
+329
to
330
| ResourceLocation lootTableId = ResourceLocation.fromNamespaceAndPath(blockEntry.getId().getNamespace(), | ||
| "blocks/" + blockEntry.getId().getPath()); |
Contributor
There was a problem hiding this comment.
Suggested change
| ResourceLocation lootTableId = ResourceLocation.fromNamespaceAndPath(blockEntry.getId().getNamespace(), | |
| "blocks/" + blockEntry.getId().getPath()); | |
| ResourceLocation lootTableId = blockEntry.getId().withPrefix("blocks/"); |
Co-authored-by: screret <68943070+screret@users.noreply.github.com>
…regTech-Modern into gus/version-parity
# Conflicts: # src/main/java/com/gregtechceu/gtceu/data/recipe/configurable/RecipeRemoval.java
screret
reviewed
Aug 4, 2026
| @ParametersAreNonnullByDefault | ||
| public class GTDynamicDataPack implements PackResources { | ||
|
|
||
| // change the path to `recipe` on 1.21!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes usages of the ResourceLocation constructor in favour of using the static construction methods. This change was made mandatory on 1.21, but can also be done on 1.20. No AI.