Reorganize GT's custom tag keys - #5240
Open
screret wants to merge 17 commits into
Open
Conversation
…s to the `lenses/glass` tag (previously it only included the uncolored glass lens)
…imes because of a typo
…ial items optional tag entries for safety's sake (by injecting an interface to the class(es))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
organized all of GT's tags into neat subclasses based on their registry type.
Also made dyed lenses be stored in an array instead of a map (it was originally a map because MarkerMaterial dn, but IMO it's easier to index with color IDs. At least it's faster if nothing else.)
AI Usage
Outcome
you can find what you're looking for now
How Was This Tested
it looks alright, no actual functionality changed
Additional Information
the lens tags were moved to the GT namespace.
Material-based items in tags were made optional entries so someone making those items not generate for whatever reason won't break the tags.
Also also fixed the Glass Lens (White) name override.
Potential Compatibility Issues
lol. lmao, even.
Anyone using CustomTags or the lens items will have to fix they codes.