Fix translation keys - #5256
Closed
1ADIS1 wants to merge 2 commits into
Closed
Conversation
Contributor
|
superseded by the lang refactor #3246 |
Member
|
Thank you for the PR, however, it won't be accepted as we already have an ongoing refactor for our language keys which already contains changes such as this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames translation keys like "recipe_category" and "recipe_type" in language files, except english ones after #4999.
Closes #5189.
Implementation Details
This PR renames
"gtceu.{MACHINE_NAME}"to"recipe_type.gtceu.{MACHINE_NAME}"and"gtceu.recipe.category"to"recipe_category.gtceu". Moves all recipe_type under recipe_category like in english language files.AI Usage
Agent Used
GPT-5.6 Sol
Agent Usage Description
AI renamed translation keys and moved them under recipe_category lines across the translation files.
Outcome
Every crafting category in EMI recipes is now correctly translated across all languages.
How Was This Tested
I tested Russian, Ukraine, and Chinese languages by switching language in language tab.
Additional Information
Probably related to #5201, but this PR targets 1.21 branch.