Skip to content

feat: propagate RDF initial snapshot completion - #8318

Closed
discord9 wants to merge 1 commit into
GreptimeTeam:mainfrom
discord9:fix/rdf-initial-snapshot-complete
Closed

feat: propagate RDF initial snapshot completion#8318
discord9 wants to merge 1 commit into
GreptimeTeam:mainfrom
discord9:fix/rdf-initial-snapshot-complete

Conversation

@discord9

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

Depends on GreptimeTeam/datafusion#8.

What's changed and what's your intention?

This PR propagates the completion state of remote dynamic filter initial snapshots.

  • Updates the DataFusion fork pin from e8a127c28e8839964bb6aefdd909810dc11cd2c9 to 96cff4fd0fcedd217151ad18e4ef4956b401f78f, which includes DynamicFilterPhysicalExpr::is_complete() from feat: expose dynamic filter completion state datafusion#8.
  • Uses alive_dyn_filter.is_complete() when building InitialDynFilterSnapshot instead of hardcoding is_complete = false.
  • Adds a unit test covering a captured remote dynamic filter whose initial snapshot is already complete.

This should land after GreptimeTeam/datafusion#8 is merged, or after we decide it is acceptable to pin GreptimeDB to that DataFusion commit directly.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

Signed-off-by: discord9 <discord9@163.com>
@discord9
discord9 requested review from a team, evenyag and waynexia as code owners June 17, 2026 08:08
@github-actions github-actions Bot added size/S docs-not-required This change does not impact docs. labels Jun 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the DataFusion dependency to a newer revision. This update allows the code to leverage a new non-blocking completion getter is_complete() on alive_dyn_filter in dyn_filter_bridge.rs, replacing a hardcoded false value. A corresponding unit test has been added to verify this behavior. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@discord9
discord9 marked this pull request as draft June 17, 2026 08:18
@discord9 discord9 closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-not-required This change does not impact docs. size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant