feat: propagate RDF initial snapshot completion - #8318
Closed
discord9 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: discord9 <discord9@163.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the DataFusion dependency to a newer revision. This update allows the code to leverage a new non-blocking completion getter is_complete() on alive_dyn_filter in dyn_filter_bridge.rs, replacing a hardcoded false value. A corresponding unit test has been added to verify this behavior. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
discord9
marked this pull request as draft
June 17, 2026 08:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
Depends on GreptimeTeam/datafusion#8.
What's changed and what's your intention?
This PR propagates the completion state of remote dynamic filter initial snapshots.
e8a127c28e8839964bb6aefdd909810dc11cd2c9to96cff4fd0fcedd217151ad18e4ef4956b401f78f, which includesDynamicFilterPhysicalExpr::is_complete()from feat: expose dynamic filter completion state datafusion#8.alive_dyn_filter.is_complete()when buildingInitialDynFilterSnapshotinstead of hardcodingis_complete = false.This should land after GreptimeTeam/datafusion#8 is merged, or after we decide it is acceptable to pin GreptimeDB to that DataFusion commit directly.
PR Checklist
Please convert it to a draft if some of the following conditions are not met.