Add voltage angles to observation vector - #770
Conversation
Signed-off-by: gaurav890 <gauravchaulagain0@gmail.com>
Not up to standards ⛔
|
|
Hello, Sorry for the really long delay in my response. I see that you took care of pretty much everything: backward compatibility and compatibility with all backends, not just the ones supporting it. That is awesome. I will have a look ASAP. Theta is "reference dependant": the same system with all theta shifted by say 10 (rad, deg or whatever unit) will be exactly the same. This was the real reason why I did not implemented it on to_vect(). Thanks for this work :-) |
|
An issue needs to be fixed:
If I read that properly it's probably because something has been added (most likely the theta) automatically to the gymnasium API and it is not declared "vector". |
BDonnot
left a comment
There was a problem hiding this comment.
One small change in the CHANGELOG.
Some tests are needed, for example in BaseObservation: to test that the obs converted to vector has the right theta information.
Signed-off-by: gaurav890 <gauravchaulagain0@gmail.com>
|
Thanks for the review. I addressed the feedback in a89de57:
I kept the raw angle values in the core vector so Local validation:
|
Summary
theta_or,theta_ex,load_theta,gen_theta, andstorage_thetato the complete observation vectorWhy
Voltage-angle attributes were only present in
attr_list_json, soto_vect()omitted them andfrom_vect()could not reconstruct them. Backends that do not expose voltage angles remain supported: Grid2Op already fills these arrays with zeros and reports their availability throughsupport_theta.Fixes #711.
Validation
python -m unittest grid2op.tests.test_Observation— 83 passed, 1 skippedpython -m unittest grid2op.tests.test_attached_envs_compat— 26 passedpython -m unittest grid2op.tests.test_Runner— 19 passedpython -m unittest grid2op.tests.test_GymConverter— 20 passed