[Bugfix] 修复 #6526: macOS 下 主题模式-跟随系统设置 失效 - #6555
Conversation
ToobLac
changed the title
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da7e36d129
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
Pull request overview
Fixes macOS system-theme following by clearing the forced native appearance when brightness is automatic.
Changes:
- Tracks whether brightness inherits system settings.
- Synchronizes macOS native appearance with that state.
- Normalizes brightness identifiers before localization.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
PersonalizationPage.java |
Normalizes brightness translation keys. |
MacOSNativeUtils.java |
Clears forced macOS appearance in automatic mode. |
Themes.java |
Exposes and maintains automatic-brightness state. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fixes #6526
不知道 Windows 下有没有类似的问题
Update：这个补丁有一个小问题，就是如果主题包设置了 overrides，在检测到深色的时候就覆盖成浅色/检测到浅色就覆盖成深色，那么文件选择器的窗口颜色就会和 HMCL 不一致。
但是我认为不会有人这么唐的所以就没管（），而且也不太好解决。