Document that a restore ends subscriptions opened before it - #699
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to specify that database subscriptions opened before a restore do not carry over to the restored data, updating both the backup operations reference and the v5.3 release notes. The review feedback recommends avoiding the use of the <VersionBadge> component at the start of a paragraph in running prose, suggesting plain text instead.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-699 This preview will update automatically when you push new commits. |
…tions with DATABASE_CLOSING Follows HarperFast/harper#2914's review: a reopen under an unchanged generation now ends the subscriptions from before it with the retryable DatabaseClosingError. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-699 This preview will update automatically when you push new commits. |
…he start of a paragraph CONTRIBUTING.md reserves VersionBadge for standalone placement after headings; the reference pages phrase a mid-section change as "As of vX". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-699 This preview will update automatically when you push new commits. |
🧹 Preview CleanupThe preview deployment for this PR has been removed. |
This branch was previously deployed
2 participants
Documents HarperFast/harper#2914 (for harper#2451): an online
restore_backupnow ends every subscription to the database that was opened before the restore. When Harper reloads the database, each subscription's last message is aDatabaseGenerationChangedError(status code 409, codeDATABASE_GENERATION_CHANGED), and the client resubscribes to resynchronize against the restored state. Before, such a subscription could stall silently, or start receiving the restored database's writes once another subscriber attached. A restore that fails before changing anything reloads the database as it was, and its subscriptions end with the retryableDatabaseClosingError(status code 503, codeDATABASE_CLOSING) instead.reference/backups/operations.md: one paragraph inrestore_backup.release-notes/v5-lincoln/5.3.md: a new Backups section with Subscriptions End When Their Database Is Restored.The reference says "As of v5.3.0" in plain text, since CONTRIBUTING.md reserves
<VersionBadge>for placement after headings. 5.3.0 is still in beta (latest tagv5.3.0-beta.4), and harper#2914 is milestoned v5.3. Merge after harper#2914, which ships the behavior.Verified with
prettier --checkon both files andnpm run build(no broken links or anchors).🤖 Generated with Claude Code