Repository navigation
Document agent.configScope and the agent's filesystem scopes, including what every scope refuses #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DavidCockerill
wants to merge
6
commits into
main
Choose a base branch
from
david/agent-config-scope
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−4
Open
Document agent.configScope and the agent's filesystem scopes, including what every scope refuses #717
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7f09592
Document agent.configScope and the agent's filesystem scopes, includi…
DavidCockerill b3339e6
Correct the agent filesystem-scope docs: write_file takes no root, wi…
DavidCockerill 8bf8b46
Name what each agent filesystem scope refuses on the operations page …
DavidCockerill 5d3f19d
Date the agent filesystem-scope change to 5.4.0, and add it to the 5.…
DavidCockerill fef8e56
Say that agent.configScope replaces the config file as the scope rath…
DavidCockerill 2f14755
Split the agent privilege-boundary bullet into separate sentences
DavidCockerill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we fix the core
tail_fileboundary before promising that a file ending partway through a PEM private key is refused? Its implementation scans only the final 1 MiB plus 64 bytes for theBEGINmarker. If a PEM block in a non-key-named file such aslog.txtstarts earlier and continues to EOF,tail_filecan return trailing base64 key text. This is a code-trace finding; I did not execute a test. A focused check is such a file withBEGINmore than 1 MiB before EOF:tail_fileshould refuse it. Please make core fail closed for that case, or state the actual limit here and in the release note.