fix: report mouse drags in button-motion (1002) tracking mode#85
Merged
Merged
Conversation
handle_cursor_moved only reported drags under MOUSE_MOTION (1003). Apps requesting button-motion tracking (1002) — e.g. tmux with `mouse on` — saw press and release but never the drag, while the widget simultaneously drew its own selection over theirs: two selection systems fighting. Check MOUSE_DRAG | MOUSE_MOTION, matching how press/release use MOUSE_MODE.
Harzu
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
handle_cursor_movedonly reports drag motion to the backend when the terminal is inMOUSE_MOTION(1003) mode. Applications that request button-motion tracking (1002) — most notably tmux withset -g mouse on— get the press and release reports but never the drag in between, while the widget simultaneously runs its ownSelectUpdateselection.The result with tmux: tmux sees click+release with no motion (so no copy-mode drag selection), while the widget paints its own selection overlay on top — two selection systems fighting over the same drag.
Fix
Check
MOUSE_DRAG | MOUSE_MOTIONwhen deciding whether to report a drag, matching how press/release already use the umbrellaMOUSE_MODE(which includes all three tracking modes). Widget-side selection still applies when neither motion mode is active (plain 1000 click-only tracking).Includes a regression test (
reports_drag_when_dragged_in_mouse_drag_mode).Repro
tmux -L testwithset -g mouse on