Skip to content

Add test cases for null-safety throw vs return semantics in constructors #12615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 6 commits into
base: development
Choose a base branch
from
Draft

Add test cases for null-safety throw vs return semantics in constructors #12615

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
96ac760
Initial plan
Copilot Feb 18, 2026
6de5af5
Fix null-safety to handle constructor branches with throw/return
Copilot Feb 18, 2026
c00b520
Fix test cases to initialize all fields in both branches
Copilot Feb 18, 2026
672dde9
Distinguish between throw and return in null-safety checks
Copilot Feb 18, 2026
b7640c4
Revert OCaml changes, keep test cases
Copilot Feb 18, 2026
f04d516
refine test cases so a better AI can take a look at some point
Simn Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 107 additions & 0 deletions tests/nullsafety/src/cases/TestStrict.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1540,3 +1540,110 @@ class BinopFlow {
});
}
}

@:build(Validator.checkFields())
class ConstructorThrowWithElse {
final s:String;

public function new() {
if (Math.random() > 0.5) {
throw "no";
} else {
s = "foo";
}
}
}

@:build(Validator.checkFields())
class ConstructorThrowNoElse {
final s:String;

public function new() {
if (Math.random() > 0.5) {
throw "no";
}
s = "foo";
}
}

@:build(Validator.checkFields())
class ConstructorThrowBothBranches {
final s:String;

public function new() {
if (Math.random() > 0.5) {
throw "no";
} else {
throw "also no";
}
}
}

@:build(Validator.checkFields())
class ConstructorReturn {
@:shouldFail final s:String;

public function new() {
if (Math.random() > 0.5) {
return;
} else {
s = "foo";
}
}
}

@:build(Validator.checkFields())
class ConstructorMixedThrowReturn {
final s:String;

public function new() {
if (Math.random() > 0.5) {
// Throw branch: doesn't need to initialize fields
throw "error";
} else {
// Return branch: must initialize all fields
s = "three";
return;
}
}
}

@:build(Validator.checkFields())
class ConstructorMixedThrowReturnFail {
@:shouldFail final s:String;

public function new() {
if (Math.random() > 0.5) {
// Throw branch: doesn't need to initialize fields
throw "error";
} else {
// Return branch: must initialize all fields, but doesn't - should fail
return;
}
}
}

@:build(Validator.checkFields())
class ConstructorEarlyReturnNoElse {
@:shouldFail final s:String;

public function new() {
if (Math.random() > 0.5) {
return;
}
s = "foo";
}
}

@:build(Validator.checkFields())
class ConstructorEarlyReturnWithElse {
@:shouldFail final s:String;

public function new() {
if (Math.random() > 0.5) {
return;
} else {
s = "foo";
}
}
}
Loading