Speed up large XML parses#12917
Open
singpolyma wants to merge 1 commit into
Open
Conversation
Creating the children array and attribute map for nodes that will never use it (text nodes, etc) is both wasteful in terms of RAM and in terms of time. Parsing a 400MB XML file this small change saves me a full second of time in benchmarks.
Member
|
Probably one of the few places where inheritance would really make sense: Have one subclass for trees (documents and elements) and one for leafs (the rest). This would replace all the node type conditionals with polymorphism and also make smaller instances on static targets (even if fields are |
Contributor
Author
|
Sure, inheritance or enum could make sense. Would have to benchmark to see the impact. This small change has a good performance impact without any API changes though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating the children array and attribute map for nodes that will never use it (text nodes, etc) is both wasteful in terms of RAM and in terms of time. Parsing a 400MB XML file this small change saves me a full second of time in benchmarks.