Skip to content

fix(packages): replace any type with proper type for error messages#5670

Open
hobostay wants to merge 1 commit into
Helicone:mainfrom
hobostay:fix/any-type-error-message
Open

fix(packages): replace any type with proper type for error messages#5670
hobostay wants to merge 1 commit into
Helicone:mainfrom
hobostay:fix/any-type-error-message

Conversation

@hobostay

Copy link
Copy Markdown

Summary

  • Replace heliconeMessage: any with string | Record<string, unknown> in LLMResponseBody type (packages/llm-mapper/types.ts:114)
  • The Gemini mappers assign an object {message, code} while other mappers assign strings - the union type accurately reflects actual usage
  • Fix typo in comment: UNORGANZIED -> UNORGANIZED

Test plan

  • Verify TypeScript compilation passes: cd packages && npx tsc --noEmit
  • Verify existing tests pass: cd packages && npx jest

Generated with Claude Code (https://claude.com/claude-code)

Replace `heliconeMessage: any` with `string | Record<string, unknown>` in
the LLMResponseBody type definition. The Gemini mappers assign an object
({message, code}) while other mappers assign strings, so the union type
accurately reflects actual usage.

Also fix typo: UNORGANZIED -> UNORGANIZED

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@vercel

vercel Bot commented May 10, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the Helicone Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel Bot temporarily deployed to Preview – helicone-bifrost May 10, 2026 10:25 Inactive

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@vercel

vercel Bot commented May 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
helicone-bifrost Skipped Skipped May 10, 2026 10:26am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant