fix(web): prevent memory leak in onboarding interval cleanup#5671
Open
hobostay wants to merge 1 commit into
Open
fix(web): prevent memory leak in onboarding interval cleanup#5671hobostay wants to merge 1 commit into
hobostay wants to merge 1 commit into
Conversation
The `startOnboarding` callback created a `setInterval` and returned a cleanup function, but the cleanup was never invoked because it was called as a regular function (not from useEffect). If onboarding was never triggered (request count never exceeded 6), the interval would run forever. Store the interval in a ref and clean it up: - On component unmount via useEffect cleanup - When starting a new onboarding check (avoid duplicate intervals) - When the onboarding condition is met Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the Helicone Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnboardingProviderwherestartOnboardingcreates asetIntervalthat is never cleaned upstartOnboarding, but since it is called as a regular callback (not from useEffect), the cleanup was never invokedBefore: If the request count never exceeded 6 (onboarding never triggered), the polling interval would run indefinitely until the page was closed.
After: The interval is properly tracked and cleaned up in all cases.
Test plan
Generated with Claude Code (https://claude.com/claude-code)