Skip to content

feat: add 5.5 models to gateway#5673

Open
H2Shami wants to merge 5 commits into
mainfrom
hammad/add-5.5
Open

feat: add 5.5 models to gateway#5673
H2Shami wants to merge 5 commits into
mainfrom
hammad/add-5.5

Conversation

@H2Shami

@H2Shami H2Shami commented May 12, 2026

Copy link
Copy Markdown
Collaborator

Ticket

Link to the ticket(s) this pull request addresses.

Component/Service

What part of Helicone does this affect?

  • Web (Frontend)
  • Jawn (Backend)
  • Worker (Proxy)
  • Bifrost (Marketing)
  • AI Gateway
  • Packages
  • Infrastructure/Docker
  • Documentation

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Performance improvement
  • Refactoring

Deployment Notes

  • No special deployment steps required
  • Database migrations need to run
  • Environment variable changes required
  • Coordination with other teams needed

Screenshots / Demos

Before After

Extra Notes

Any additional context, considerations, or notes for reviewers.

Context

Why are you making this change?

Screenshots / Demos

Copilot AI review requested due to automatic review settings May 12, 2026 21:18
@vercel

vercel Bot commented May 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
helicone Error Error May 14, 2026 11:09pm
helicone-bifrost Error Error May 14, 2026 11:09pm
helicone-eu Error Error May 14, 2026 11:09pm

Request Review

@supabase

supabase Bot commented May 12, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project bolqqmqbrciybnypvklh because there are no changes detected in supbase/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@supabase

supabase Bot commented May 12, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project lmahfbbnchpworytrrqk because there are no changes detected in .supabase/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@claude

claude Bot commented May 12, 2026

Copy link
Copy Markdown
Contributor

Claude finished @H2Shami's task —— View job


PR Review: Add 5.5 models to gateway

Todo List:

  • Read and analyze changed files
  • Review for critical bugs and security issues
  • Check code quality and best practices
  • Identify refactoring opportunities
  • Assess breaking changes or API issues
  • Provide detailed feedback with suggestions
  • Assign confidence score and summary

Score: 3/10 - Critical integration issue prevents models from being discoverable, plus several other important fixes needed.

Critical Issues Found

🚨 Models Not Integrated into Registry

File: packages/cost/models/authors/openai/index.ts

  • Problem: The new GPT-5.5 models and endpoints are not imported/exported in the main OpenAI registry
  • Impact: Models will not be discoverable by the gateway despite being defined
  • Fix: Add these imports and exports:
// Add to imports
import { models as gpt55Models } from "./gpt-5.5/models";
import { endpoints as gpt55Endpoints } from "./gpt-5.5/endpoints";

// Add to model aggregation (line 47)
export const openaiModels = {
  ...gpt54Models,
  ...gpt55Models, // Add this line
  ...ossModels,
  ...gptImage1Models,
} satisfies Record<string, ModelConfig>;

// Add to endpoint aggregation (line 62)
export const openaiEndpointConfig = {
  ...gpt54Endpoints,
  ...gpt55Endpoints, // Add this line
  ...ossEndpoints,
  ...gptImage1Endpoints,
} satisfies Record<string, ModelProviderConfig>;

Major Issues

Inconsistent Model Pattern

File: packages/cost/models/authors/openai/gpt-5.5/models.ts:5-16

  • Problem: Missing versioned model entry that follows established pattern from other OpenAI models
  • Pattern: Other models (like GPT-5.4) have both "gpt-5.4" and "gpt-5.4-2026-03-05" entries
  • Fix: Add the dated model entry:
export const models = {
  "gpt-5.5": {
    name: "OpenAI GPT-5.5",
    // ... existing config
  },
  "gpt-5.5-2026-04-23": {  // Add this entry
    name: "OpenAI GPT-5.5",
    author: "openai",
    description: "GPT-5.5 is our newest frontier model for the most complex professional work...",
    contextLength: 1_050_000,
    maxOutputTokens: 128_000,
    created: "2026-04-23T00:00:00.000Z",
    modality: { inputs: ["text", "image"], outputs: ["text"] },
    tokenizer: "GPT",
    pinnedVersionOfModel: "gpt-5.5",
  },
} satisfies Record<string, ModelConfig>;

Type Name Inconsistency

Files: models.ts:18 and endpoints.ts:3

  • Problem: Type is named GPT55ModelName but imported as GPT54ModelName in endpoints.ts
  • Fix: Update endpoints.ts line 3:
import { GPT55ModelName } from "./models"; // Fix import name

Minor Issues

Provider Model ID Inconsistency

File: packages/cost/models/authors/openai/gpt-5.5/endpoints.ts:7

  • Problem: Endpoint key is "gpt-5.5:openai" but uses dated providerModelId: "gpt-5.5-2026-04-23"
  • Pattern: Other models typically use unversioned providerModelId for unversioned keys
  • Fix: Either:
    1. Change to providerModelId: "gpt-5.5", OR
    2. Add separate endpoint for dated version

Missing Provider Support

File: endpoints.ts - Missing Azure and Helicone endpoints

  • Observation: GPT-5.4 has 4 providers (OpenAI, OpenRouter, Azure, Helicone), but GPT-5.5 only has 2
  • Impact: May limit deployment flexibility
  • Suggestion: Consider if Azure/Helicone support is planned

Code Quality Notes

Good Practices Followed:

  • ✅ Proper TypeScript typing with satisfies
  • ✅ Consistent pricing structure with tiered thresholds
  • ✅ Proper parameter categorization (supported/unsupported)
  • ✅ Rate limit definitions match GPT-5.4 pattern
  • ✅ Web search pricing included consistently

PTB Intentionally Disabled:

  • Author confirmed ptbEnabled: false is intentional
  • This means GPT-5.5 won't be available for PTB (Prompt-to-Batch) routing initially

Security & Performance

  • ✅ No security issues identified
  • ✅ No performance concerns
  • ✅ Pricing calculations appear correct
  • ✅ Rate limits are appropriately set

Suggestions Summary:

Critical (Must Fix):

  • Integrate models into main OpenAI registry (index.ts)
  • Add versioned model entry to follow established pattern

Important (Should Fix):

  • Fix type import inconsistency in endpoints.ts
  • Align provider model ID pattern with other models

Nice to Have:

  • Consider adding Azure/Helicone provider support for consistency

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds cost-model registry entries intended to introduce OpenAI GPT‑5.5 into Helicone’s packages/cost model catalog (models + provider endpoints) so the gateway/registry can price and route the model consistently.

Changes:

  • Adds a new OpenAI author sub-registry for gpt-5.5 model metadata.
  • Adds provider endpoint configs for gpt-5.5 for OpenAI and OpenRouter, including pricing + supported parameter lists.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File Description
packages/cost/models/authors/openai/gpt-5.5/models.ts Introduces GPT‑5.5 model metadata entries.
packages/cost/models/authors/openai/gpt-5.5/endpoints.ts Introduces provider endpoint configs (OpenAI/OpenRouter) for GPT‑5.5 including pricing/limits/params.
Comments suppressed due to low confidence (1)

packages/cost/models/authors/openai/gpt-5.5/models.ts:20

  • This gpt-5.5 models registry includes a "gpt-5.4-2026-03-05" entry, which appears to be copied from the gpt-5.4 folder and would incorrectly expose a 5.4 model under the 5.5 author path. Replace this with the appropriate gpt-5.5 versioned model key (e.g., "gpt-5.5-2026-04-23") and ensure pinnedVersionOfModel references "gpt-5.5".
  "gpt-5.4-2026-03-05": {
    name: "OpenAI GPT-5.4",
    author: "openai",
    description:
      "GPT-5.4 is our frontier model for complex professional work. Reasoning.effort supports: none (default), low, medium, high and xhigh. Features a 1.05M context window and 128K max output tokens with improvements in general intelligence, instruction following, accuracy, multimodality, code generation, tool calling, and context management over GPT-5.2.",

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/cost/models/authors/openai/gpt-5.5/models.ts Outdated
Comment thread packages/cost/models/authors/openai/gpt-5.5/models.ts Outdated
Comment thread packages/cost/models/authors/openai/gpt-5.5/endpoints.ts
Comment thread packages/cost/models/authors/openai/gpt-5.5/endpoints.ts
Comment thread packages/cost/models/authors/openai/gpt-5.5/endpoints.ts
Comment thread packages/cost/models/authors/openai/gpt-5.5/endpoints.ts Outdated
Comment thread packages/cost/models/authors/openai/gpt-5.5/endpoints.ts
@vercel vercel Bot temporarily deployed to Preview – helicone-bifrost May 14, 2026 22:33 Inactive
@vercel vercel Bot temporarily deployed to Preview – helicone-bifrost May 14, 2026 22:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants