chore: fix typo in retry-exhausted error message (occured -> occurred)#5677
Open
Chen17-sq wants to merge 1 commit into
Open
chore: fix typo in retry-exhausted error message (occured -> occurred)#5677Chen17-sq wants to merge 1 commit into
Chen17-sq wants to merge 1 commit into
Conversation
Both retry helpers (valhalla/jawn and worker) throw "500 An error occured while retrying your requests" when all retries fail. "occured" is a common misspelling of "occurred". This message is user-visible when the provider remains unreachable across the entire retry budget, so the typo can surface in production logs. Pure string change. No logic, control flow, or test affected.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both retry helpers in this repo (
valhalla/jawn/src/lib/proxy/ProviderClient.tsandworker/src/lib/clients/ProviderClient.ts) throw"500 An error occured while retrying your requests"when all retries fail.occuredis a common misspelling ofoccurred. The string is user-visible — it propagates up when the provider remains unreachable across the entire retry budget, so it can surface in production logs and on-call traces.Scope
Pure string change in two files. No logic, control flow, or test affected.
Test plan
valhalla/jawn/src/orworker/src/.