feat: add defaultValue support for showFontPicker in puter app environment#3403
Open
smz202000 wants to merge 1 commit into
Open
feat: add defaultValue support for showFontPicker in puter app environment#3403smz202000 wants to merge 1 commit into
smz202000 wants to merge 1 commit into
Conversation
…nment Add support for the 'defaultValue' option in puter.ui.showFontPicker(), for consistency with showColorPicker() which already supports it. Changes: - UI.js (web fallback): Include defaultValue in the font resolution chain - IPC.js (app environment): Map defaultValue to default before calling UIWindowFontPicker - UIWindowFontPicker.js: Check defaultValue alongside default when highlighting the active font - ui.d.ts: Add defaultValue to FontPickerOptions type definition
|
|
Member
|
@smz202000 could you sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
defaultValueoption inputer.ui.showFontPicker(), for consistency withshowColorPicker()which already supportsdefaultValue.When calling
showFontPickerfrom a Puter app, passingdefaultValueas an option would not pre-select the specified font because:defaultValuetodefaultbefore passing to the desktop UIUIWindowFontPicker) only checkedoptions.defaultdefaultFontanddefaultChanges
opts.defaultValueto the font resolution chaindefaultValuetodefaultbefore callingUIWindowFontPickerdefaultValuealongsidedefaultwhen highlighting the active fontdefaultValuetoFontPickerOptionsinterfaceRelated Issue
Closes #2896