Merged
Conversation
Add `--enable-experimental-rspec` to the Sorbet config so that Sorbet type-checks RSpec spec files. This is an isolated piece of the work in #21690, separated so that the follow-up work of dialling up the `typed:` level of individual specs can land independently. Enabling the flag surfaced a pre-existing type error in `formula-analytics/pycall-setup.rbi` where `InfluxDBClient3#initialize` was incorrectly declared as a singleton method (`def self.initialize`) rather than an instance method (`def initialize`). Fixed here since the error is only visible with RSpec mode enabled.
dduugg
force-pushed
the
sorbet-enable-experimental-rspec
branch
from
81a09e7 to
8384332
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Enables Sorbet’s experimental RSpec support so RSpec specs can be type-checked with improved DSL awareness, and fixes a related RBI signature issue discovered by the stricter checking.
Changes:
- Add
--enable-experimental-rspecto the Sorbet typechecker config. - Fix
InfluxDBClient3#initializein an RBI stub to be an instance method rather than a singleton method.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Library/Homebrew/sorbet/config |
Enables Sorbet’s experimental RSpec mode during srb tc. |
Library/Homebrew/formula-analytics/pycall-setup.rbi |
Corrects InfluxDBClient3#initialize stub to match Ruby semantics (instance initializer). |
Files not reviewed (1)
- Library/Homebrew/formula-analytics/pycall-setup.rbi: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
12 tasks
MikeMcQuaid
approved these changes
Mar 15, 2026
issyl0
added a commit
that referenced
this pull request
Mar 29, 2026
- Now that we've enabled `--experimental-rspec-mode` [1], let's start using Sorbet in tests at its basic `typed: false` level for now. - This will ease the migration to `typed: true` of any or all tests we want to do in the future. [1]: #21742
6 tasks
issyl0
added a commit
that referenced
this pull request
Mar 29, 2026
- Now that we've enabled `--experimental-rspec-mode` [1], let's start using Sorbet in tests at its basic `typed: false` level for now. - This will ease the migration to `typed: true` of any or all tests we want to do in the future. [1]: #21742
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?Claude Code was used to draft the commit message and PR description. The changes themselves were authored by the human. The diff was reviewed manually before committing.
Adds
--enable-experimental-rspecto the Sorbet config so that Sorbet type-checks RSpec spec files. This is an isolated piece of #21690, separated so that the follow-up work of dialling up thetyped:level of individual specs can land independently.Enabling the flag surfaced a pre-existing type error in
formula-analytics/pycall-setup.rbiwhereInfluxDBClient3#initializewas incorrectly declared as a singleton method (def self.initialize) rather than an instance method (def initialize).No new tests are needed — the change is to Sorbet configuration and an RBI stub file; correctness is verified by
brew typecheckpassing.