Skip to content

docker: use 24.04 for ghcr.io/homebrew/brew #21768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cho-m wants to merge 1 commit into from
Closed

docker: use 24.04 for ghcr.io/homebrew/brew #21768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,15 @@ jobs:
"ghcr.io/homebrew/ubuntu${version}:${brew_version}"
"ghcr.io/homebrew/ubuntu${version}:latest"
)
if [[ "${version}" == "22.04" ]]; then
if [[ "${version}" == "24.04" ]]; then
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change the Homebrew/homebrew-core default CI image?

Copy link
Copy Markdown
Member Author

@cho-m cho-m Mar 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this only impacts container label ghcr.io/homebrew/brew which we currently don't use in Homebrew/homebrew-core.

As far as I'm aware, bottling runners is a mix of:

A bit messy as we currently have to update multiple locations. Maybe we should be using a dedicated/unversioned container label for bottling so we don't have to worry about these being updated in-sync.

Copy link
Copy Markdown
Member Author

@cho-m cho-m Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should be using a dedicated/unversioned container label for bottling so we don't have to worry about these being updated in-sync.

If we want to use ghcr.io/homebrew/brew:main for this, then can close this PR and handle as part of Ubuntu migration PR.

tags+=(
"ghcr.io/homebrew/brew:${brew_version}"
"ghcr.io/homebrew/brew:latest"
)
fi
elif [[ "${GITHUB_EVENT_NAME}" == "push" &&
("${GITHUB_REF}" == "refs/heads/main") ]]; then
if [[ "${version}" == "22.04" ]]; then
if [[ "${version}" == "24.04" ]]; then
tags+=("ghcr.io/homebrew/brew:main")
fi
tags+=("ghcr.io/homebrew/ubuntu${version}:main")
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG version=22.04
ARG version=24.04
# version is passed through by Docker.
# shellcheck disable=SC2154
FROM ubuntu:"${version}"
Expand Down
Loading