How-To-Open-a-Homebrew-Pull-Request: clarify brew audit --new for new formulae#22063
How-To-Open-a-Homebrew-Pull-Request: clarify brew audit --new for new formulae#22063EoinTrial wants to merge 5 commits intoHomebrew:masterfrom
brew audit --new for new formulae#22063Conversation
…for changed formulae
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks! I wonder if it makes sense to have --new referenced in the code block below. It may also make sense to recommend brew lgtm in this case; can you try that and see if it does the right thing here?
|
@MikeMcQuaid Thanks for taking a look! Have added a separate code block for new formulae using |
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Thanks! Not sure if all these work or correct but: think this would be the ideal state!
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
|
@MikeMcQuaid Thanks for your support with this - PR updated! |
|
@EoinTrial can you confirm that the changes I've suggested actually work as expected 😅? Also note the small CI failure 🔴 https://github.com/Homebrew/brew/actions/runs/24787486986/job/72535477934?pr=22063 |
|
@MikeMcQuaid Hey, when I tested locally,
|
brew lgtmwith your changes locally?Adding-Software-to-Homebrew.md. The one-line change was written and reviewed manually.The guide currently shows
brew audit --strict --onlinefor changed formulae, which is correct. However, it doesn't distinguish this from the new formula case. A contributor adding a new formula following this guide would not know to usebrew audit --new, which runs additional new-formula eligibility checks (and implies--strictand--online). This is already documented correctly inAdding-Software-to-Homebrew.mdbut the cross-reference is missing here.