Skip to content

forgecode 2.11.5 (new formula)#278755

Open
gliptak wants to merge 1 commit intoHomebrew:mainfrom
gliptak:forgecode1
Open

forgecode 2.11.5 (new formula)#278755
gliptak wants to merge 1 commit intoHomebrew:mainfrom
gliptak:forgecode1

Conversation

@gliptak
Copy link
Copy Markdown

@gliptak gliptak commented Apr 22, 2026


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

@github-actions github-actions Bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Apr 22, 2026
Comment thread Formula/f/forgecode.rb Outdated
Comment thread Formula/f/forgecode.rb Outdated
Comment on lines +10 to +13
livecheck do
url :stable
strategy :github_latest
end
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to specify livecheck block unless the default strategy doesn't work as expected

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to validate if default strategy works? am I to remove this livecheck?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check it by running brew livecheck forgecode. In this specific case it should be fine to just remove the block

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or brew livecheck --autobump forgecode

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating

Comment thread Formula/f/forgecode.rb Outdated
Comment thread Formula/f/forgecode.rb Outdated
end

test do
assert_match "Version:", shell_output("#{bin}/forge banner 2>&1")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assert_match "Version:", shell_output("#{bin}/forge banner 2>&1")
assert_match version.to_s, shell_output("#{bin}/forge banner 2>&1")

Homebrew requires a simple test that checks if a program can do basic stuff correctly. From Formula Cookbook:

We want tests that don’t require any user input and test the basic functionality of the application. For example foo build-foo input.foo is a good test and (despite their widespread use) foo --version and foo --help are bad tests. However, a bad test is better than no test at all.

If software requires credentials (f.e. LLM provider API key):

If the software cannot function without credentials or requires a virtual machine, docker instance, etc. to run, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected. This is preferred over mocking a dependency.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During first run, forge shows an AI selection TUI. I'm not sure how to check against it

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's possible to select LLM model by providing cli-args/via environment variables? Also you can try to use Open3.popen3 to write/read from stdin and stdout. If nether of these is possible, please add a comment (something like # forgecode is a TUI application)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating

@github-actions github-actions Bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 22, 2026
@gliptak
Copy link
Copy Markdown
Author

gliptak commented Apr 22, 2026

now it Commit style error without specifics. I can squash it locally maybe

@gliptak gliptak requested a review from botantony April 22, 2026 01:17
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@github-actions github-actions Bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants