Conversation
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
botantony
left a comment
There was a problem hiding this comment.
Hello @origamimochi. This looks like a nice piece of software, but it currently does not meet the notability requirements for inclusion into Homebrew-core: https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff
For now you can create and maintain your own tap:
- https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap
- https://brew.sh/2020/11/18/homebrew-tap-with-bottles-uploaded-to-github-releases/
Once it becomes notable enough, we would love to see it in the Homebrew-core repository
| end | ||
|
|
||
| test do | ||
| assert_match version.to_s, shell_output("#{bin}/onecli version") |
There was a problem hiding this comment.
Homebrew requires a simple test that checks if a program can do basic stuff correctly. From Formula Cookbook:
We want tests that don’t require any user input and test the basic functionality of the application. For example
foo build-foo input.foois a good test and (despite their widespread use)foo --versionandfoo --helpare bad tests. However, a bad test is better than no test at all.
| -s -w | ||
| -X main.version=#{version} | ||
| ] | ||
| system "go", "build", *std_go_args(ldflags: ldflags, output: bin/"onecli"), "./cmd/onecli" |
There was a problem hiding this comment.
| system "go", "build", *std_go_args(ldflags: ldflags, output: bin/"onecli"), "./cmd/onecli" | |
| system "go", "build", *std_go_args(ldflags:), "./cmd/onecli" |
| livecheck do | ||
| url :stable | ||
| strategy :github_latest | ||
| end | ||
|
|
There was a problem hiding this comment.
Don't add livecheck block unless the default strategy doesn't work as expected
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?