Skip to content

onecli-cli 1.3.0 (new formula)#278855

Open
origamimochi wants to merge 1 commit intoHomebrew:mainfrom
origamimochi:onecli-cli
Open

onecli-cli 1.3.0 (new formula)#278855
origamimochi wants to merge 1 commit intoHomebrew:mainfrom
origamimochi:onecli-cli

Conversation

@origamimochi
Copy link
Copy Markdown


  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?
  • Is your test running fine brew test <formula>?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

@github-actions github-actions Bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Apr 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Copy link
Copy Markdown
Member

@botantony botantony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @origamimochi. This looks like a nice piece of software, but it currently does not meet the notability requirements for inclusion into Homebrew-core: https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff

For now you can create and maintain your own tap:

Once it becomes notable enough, we would love to see it in the Homebrew-core repository

Comment thread Formula/o/onecli-cli.rb
end

test do
assert_match version.to_s, shell_output("#{bin}/onecli version")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Homebrew requires a simple test that checks if a program can do basic stuff correctly. From Formula Cookbook:

We want tests that don’t require any user input and test the basic functionality of the application. For example foo build-foo input.foo is a good test and (despite their widespread use) foo --version and foo --help are bad tests. However, a bad test is better than no test at all.

Comment thread Formula/o/onecli-cli.rb
-s -w
-X main.version=#{version}
]
system "go", "build", *std_go_args(ldflags: ldflags, output: bin/"onecli"), "./cmd/onecli"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
system "go", "build", *std_go_args(ldflags: ldflags, output: bin/"onecli"), "./cmd/onecli"
system "go", "build", *std_go_args(ldflags:), "./cmd/onecli"

Comment thread Formula/o/onecli-cli.rb
Comment on lines +9 to +13
livecheck do
url :stable
strategy :github_latest
end

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add livecheck block unless the default strategy doesn't work as expected

@botantony botantony added the notability Project is not notable enough for inclusion label Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core notability Project is not notable enough for inclusion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants