fix: TimeSeries overviewWidth ignored due to PersistentState restore (#9818) - #9827
Open
johntomcat7408-cmyk wants to merge 1 commit into
Conversation
johntomcat7408-cmyk
requested review from
a team,
hlomzik and
nick-skriabin
as code owners
July 17, 2026 15:28
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for label-studio-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
m-hilal
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
overviewWidthhas no effect (#9818).PersistentStateMixinrestores the storedbrushRangewhen the{task}fingerprint matches, andupdateValuethen skipsthe config default. The playground sample task id is always 1, so the stored view
always wins there, and a config change never invalidates it.
Fix: add
tagandoverviewwidthto the fingerprint so a config changeinvalidates the stored view; skip store/restore when a fingerprint value is
undefined (no task). Same task + same config still restores the last view.
Brief change log
TimeSeries.jsx: fingerprint now includestagandoverviewwidth.PersistentState.js: skip store/restore on undefined fingerprint values.TimeSeries.test.js: 4 unit tests for the above.Verifying this change
Reproduced in a mobx-state-tree harness: before the fix
overviewWidth="100%"left
brushRangeat the stored 25% range; after it the new default applies onconfig change, same task + config restores the last view, nothing is stored
without a task id. Video (own key, empty fingerprint) is unaffected.
Fixes #9818.