fix: restore grpcio-reflection test dep for python 3.10 - #9889
Open
nikitabelonogov wants to merge 1 commit into
Open
fix: restore grpcio-reflection test dep for python 3.10#9889nikitabelonogov wants to merge 1 commit into
nikitabelonogov wants to merge 1 commit into
Conversation
Commit 3e9c6b3 (BROS-1527, synced from the monorepo) regenerated pyproject.toml/uv.lock from a base that predates #9882 and silently dropped the grpcio-reflection test dependency. On Python 3.10 tavern 2.x unconditionally loads its grpc plugin (grpcio is present transitively), so every tavern test errors at setup with PluginLoadError: No module named 'grpc_reflection' — 165 failures in the LS SQLite Ubuntu/Windows (3.10) jobs on develop. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
❌ Deploy Preview for label-studio-storybook failed. Why did it fail? →
|
❌ Deploy Preview for label-studio-playground failed. Why did it fail? →
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tests / LS SQLite Ubuntu (3.10)(and Windows 3.10) fail on develop with 167 failed tests (example run). 165 of them are tavern tests all erroring at setup with:(The remaining 2 are the known order-dependent
TestColdStartScenariosflakes, unrelated.)Root cause
Python 3.10 uses tavern 2.17.0, which unconditionally loads its grpc plugin whenever
grpciois importable (it is, transitively viagoogle-api-core[grpc]), and the plugin requiresgrpc_reflection. #9882 addedgrpcio-reflection==1.78.0 ; python_full_version < '3.11'to the test group for exactly this reason.Commit 3e9c6b3 (BROS-1527, a frontend video fix synced from the monorepo with GitOrigin-RevId) regenerated
pyproject.toml/uv.lockfrom a base that predates that fix and silently reverted the dependency. Python ≥3.11 jobs are unaffected because tavern 3.3.3 doesn't have this behavior.Fix
Re-add the dependency (with a comment explaining why it exists, to make the next accidental revert more visible) and regenerate the lock. The lock diff is minimal — only the
grpcio-reflectionentries, identical hashes to the original fix.Verification
On Python 3.10 with
uv sync --frozen --group test:tavern_grpcentry point loads cleanlypytest label_studio/tests/data_manager/filters/int.tavern.yml→ 4 passed (these fail on develop)This is the second time a monorepo-synced commit clobbered these files. The same dependency line needs to be added on the monorepo side, otherwise the next sync that touches
pyproject.toml/uv.lockwill revert it again.🤖 Generated with Claude Code