Repository navigation
fix(starter-kit): integrate OpenShell deployment with RHOAI - #227
Conversation
Signed-off-by: Wojciech Rebisz <147821486+Wojciech-Rebisz@users.noreply.github.com>
LukaszCmielowski
left a comment
There was a problem hiding this comment.
AI assisted - review before making any changes:
-
P1 — Preserve Kubernetes API certificate trust (
). Replacing the cluster CA with the public CA bundle breaks TokenReview on clustersai4rag/ai4rag/assets_generator/starter_kit_templates/agentic_rag/Makefile
Lines 242 to 244 in 21395f4
using private API certificates. Valid requests return 401, while /health still passes. Pass the CA configured for the selected API endpoint into the sandbox. -
P2 — Read complete CONNECT headers (
). The parser stops after the request line. When headers arrive across multiple
reads, remaining headers leak into the upstream TLS/database stream. I reproduced this locally. Consume headers through \r\n\r\n before tunneling, preserving any subsequent payload bytes.
Signed-off-by: Wojciech Rebisz <147821486+Wojciech-Rebisz@users.noreply.github.com>
LukaszCmielowski
left a comment
There was a problem hiding this comment.
Looks like some remaining items:
• Kubernetes API CA: partially fixed. It uploads a cluster bundle, but always prefers trusted-ca-bundle when present—even if that bundle lacks the API server’s private CA. The previous issue therefore remains for those clusters.
• Custom namespace TLS: still broken. Certificate names still hardcode openshell, while the gateway URL uses the configured namespace. This was an additional finding from the latest review.
…istry if needed Signed-off-by: Wojciech Rebisz <147821486+Wojciech-Rebisz@users.noreply.github.com>
…ertificates Signed-off-by: Wojciech Rebisz <147821486+Wojciech-Rebisz@users.noreply.github.com>
Signed-off-by: Wojciech Rebisz <147821486+Wojciech-Rebisz@users.noreply.github.com>
Description
Brief summary of changes
Motivation
Why is this change needed?
Changes
Testing
How did you test this?
Checklist