Skip to content

Don't singleton batched tasks rings before executing them #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devreal wants to merge 1 commit into from
Closed

Don't singleton batched tasks rings before executing them #790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion parsec/mca/device/device_gpu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2918,8 +2918,13 @@ parsec_device_kernel_exec( parsec_device_gpu_module_t *gpu_device,
/* The submit hook may turn gpu_task into a batch ring. Start from a clean
* singleton so stale list links left by release-mode list operations cannot
* be mistaken for a preexisting ring.
* However, if the task returned PARSEC_HOOK_RETURN_AGAIN, we must preserve the
* ring as it may contain the follower tasks of the batch.
*/
PARSEC_LIST_ITEM_SINGLETON(&gpu_task->list_item);
if (gpu_task->last_status != PARSEC_HOOK_RETURN_AGAIN) {
/* The task is being rescheduled, we need to reset the status */
PARSEC_LIST_ITEM_SINGLETON(&gpu_task->list_item);
}
Comment on lines +2924 to +2927

(void)this_task;
rc = progress_fct( gpu_device, gpu_task, gpu_stream );
Expand Down
Loading