Don't persist events,incident_events to DB#423
Open
yhabteab wants to merge 1 commit into
Open
Conversation
yhabteab
force-pushed
the
do-not-persist-events-to-database
branch
from
95b3aa7 to
14bab60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that no
eventandincident_eventrecords are persisted in the database as requested in the referenced issue. Also, @julianbrost suggested in the referenced issue that theeventdatabase table might be used in the future for job queuing required for HA, but I don't think we will be storing a serialized form of the event in the database for that purpose, so I have removed theeventtable as well. Additionally, I have added a debug log with all the relevant fields of the request, so that one has something to look at when debugging why or why not an event rule matched or not.resolves #392