Skip to content

Fix IV0016 docs, remove dead diagnostic constants, fix MinLength/MaxLength inclusive-bound messages - #298

Merged
viceroypenguin merged 1 commit into
mainfrom
copilot/fix-issues-294-295-296
Jul 27, 2026
Merged

Fix IV0016 docs, remove dead diagnostic constants, fix MinLength/MaxLength inclusive-bound messages#298
viceroypenguin merged 1 commit into
mainfrom
copilot/fix-issues-294-295-296

Conversation

Copilot AI commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Three unrelated housekeeping fixes bundled together.

#294 — IV0016 marked as removed in analyzer docs

Immediate.Validations.Analyzers.md still listed IV0016 as an active rule despite it being removed in 2.3. Section now annotated (Removed in 2.3) with Enabled: False.

#295 — Dead diagnostic constants removed

DiagnosticIds.cs contained two constants with no analyzer, no descriptor, and no release entry:

  • IV0019ValidatorIsMissingDefaultMessage — leftover from a rename; IV0010 covers this case
  • IV0016ValidateParameterPropertyIncompatibleType — orphaned after IV0016 was removed in 2.3

#296 — MinLength/MaxLength messages corrected to inclusive bounds

Both validators use >= / <= but their default messages said more than / less than (exclusive).

Validator Before After
MinLength must be more than {N} characters must be at least {N} characters
MaxLength must be less than {N} characters must be at most {N} characters

Updated EN and FR localizations. Updated all affected test assertions and added explicit boundary-value tests confirming that a value at exactly the limit passes.

…stants, fix MinLength/MaxLength messages
@viceroypenguin
viceroypenguin marked this pull request as ready for review July 27, 2026 23:39
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 30314613686

Coverage decreased (-4.3%) to 83.852%

Details

  • Coverage decreased (-4.3%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 114 coverage regressions across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

114 previously-covered lines in 1 file lost coverage.

File Lines Losing Coverage Coverage
src/Common/ITypeSymbolExtensions.cs 114 18.32%

Coverage Stats

Coverage Status
Relevant Lines: 2217
Covered Lines: 1859
Line Coverage: 83.85%
Coverage Strength: 3.35 hits per line

💛 - Coveralls

@viceroypenguin
viceroypenguin merged commit 4c2785e into main Jul 27, 2026
1 of 2 checks passed
@viceroypenguin
viceroypenguin deleted the copilot/fix-issues-294-295-296 branch July 27, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants