Fix IV0016 docs, remove dead diagnostic constants, fix MinLength/MaxLength inclusive-bound messages - #298
Merged
Conversation
…stants, fix MinLength/MaxLength messages
Copilot
AI
changed the title
Fix issues #294, #295, #296
Fix IV0016 docs, remove dead diagnostic constants, fix MinLength/MaxLength inclusive-bound messages
Jul 27, 2026
Copilot created this pull request from a session on behalf of
viceroypenguin
July 27, 2026 23:35
View session
This was
linked to
issues
Jul 27, 2026
viceroypenguin
approved these changes
Jul 27, 2026
viceroypenguin
marked this pull request as ready for review
July 27, 2026 23:39
Coverage Report for CI Build 30314613686Coverage decreased (-4.3%) to 83.852%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions114 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three unrelated housekeeping fixes bundled together.
#294 — IV0016 marked as removed in analyzer docs
Immediate.Validations.Analyzers.mdstill listed IV0016 as an active rule despite it being removed in 2.3. Section now annotated(Removed in 2.3)withEnabled: False.#295 — Dead diagnostic constants removed
DiagnosticIds.cscontained two constants with no analyzer, no descriptor, and no release entry:IV0019ValidatorIsMissingDefaultMessage— leftover from a rename; IV0010 covers this caseIV0016ValidateParameterPropertyIncompatibleType— orphaned after IV0016 was removed in 2.3#296 — MinLength/MaxLength messages corrected to inclusive bounds
Both validators use
>=/<=but their default messages said more than / less than (exclusive).MinLengthmust be more than {N} charactersmust be at least {N} charactersMaxLengthmust be less than {N} charactersmust be at most {N} charactersUpdated EN and FR localizations. Updated all affected test assertions and added explicit boundary-value tests confirming that a value at exactly the limit passes.