-
-
Notifications
You must be signed in to change notification settings - Fork 32
Improve ethernet handling, add PCAP as a network implementation #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nbriggs
wants to merge
51
commits into
master
Choose a base branch
from
nhb-pcap-ethernet
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 22 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
eedc8a5
Uses endian independent structure layouts to access returned ethernet…
nbriggs cdaa7b6
Cleans up the interrupt state structure to match Lisp naming
nbriggs a074c4a
Adds required include of <string.h> for strncpy in non-BYTESWAP compi…
nbriggs 5432d73
Adds generation of SIGIO on X11 connection if O_ASYNC defined
nbriggs 3a4a943
Merge branch 'master' into nhb-pcap-ethernet
nbriggs 6c80962
Replaces display subsystem specific procedures with process_Display_e…
nbriggs 116aba2
Adds new ethernet implementation ether_pcap.c, enabled in subsequent …
nbriggs c10b512
Further clean up of boolean extended_frame in llstk.c
nbriggs 3cdbaf8
Minor updates to timer and I/O signalling
nbriggs 156208e
Cleanup in ldeether
nbriggs 7661a97
Adds raw XNS ethernet packet access via the PCAP library, along with …
nbriggs 967a227
Response to Gemini review - truncate overly large ether packets
nbriggs fc4e89f
Avoid buffer overflow parsing ldex.EtherNet interface name for pcap mode
nbriggs ea468cd
Addresses "major" complaints from Gemini review
nbriggs 6f277ed
Addresses additional error handling and setup order complaints
nbriggs 3038906
Cleanly update PENDINGINTERRUPT when a frame has been extended
nbriggs 959b523
Introduces XrmValueCopy to safely copy a value{address, size} into a …
nbriggs e874b31
Cleans up signedness mismatch on ether_ifname string
nbriggs ba914df
Add comments re ideas on -E option parsing and restructure slightly
nbriggs 36ce427
Improves robustness of handling pcap_next_ex() results and error repo…
nbriggs 1de5296
Handle case where PCAP selectable fd is greater than FD_SETSIZE
nbriggs e3f65ba
Update comments to help Gemini get over its mistaken idea of the max …
nbriggs de1ce7b
Fixes uninitialized fd set in SunOS/Solaris check_ether code.
nbriggs b410f13
Handles errors (unlikely) from pcap_inject(); updates comment on XNS …
nbriggs 443f356
Adds safety check to XrmValueCopy for passing NULL for dst or 0 for d…
nbriggs 2c39b39
Removes unnecessary include nlist.h from ether_pcap.c
nbriggs f7e605e
Use common style for declaration of ethernet addresses in ether_addr_…
nbriggs f970d24
Corrects erroneous use of bitwise-and in place of logical and.
nbriggs eee15b1
Fixes missing void in parameterless procedure decl. Removes unused v…
nbriggs b50f976
Improves ease-of-use of -E option (pcap) by allowing -E interface-name
nbriggs 9761836
Minor cleanup for pcap_next_ex() packet type, safety check on addr le…
nbriggs f7284f2
Remove unused xfd in X_init, setting async i/o has to be deferred.
nbriggs c964877
improves accuracy for periodic interrupt frequency calculation (maybe)
nbriggs c579084
Improves the error messages for bad -E/ldex.EtherNet resources
nbriggs b0706d4
Eliminates strncpy() in main.c in favor of snprintf()
nbriggs 9812285
Reinstates maxpages limit X resource on contiguous pages dumped in sy…
nbriggs 1a5196c
Eliminates strncpy in favor of memcpy for moving non null-terminated …
nbriggs 374a41e
Eliminates strncpy() in favor of memcpy()/snprintf()
nbriggs 81d993d
Eliminates strncpy() in favor of memcpy() for body of BCPL string.
nbriggs af4a1f6
Eliminates a stpncpy/strncpy pair in favor of an snprintf()
nbriggs ba77097
Eliminates strncpy() in favor of memcpy() since not a null-terminated…
nbriggs c7d2676
Eliminates strcpy()/strncpy() in favor of memcpy()
nbriggs f8f4ddf
Eliminate unnecessry strlcpy()/strlcat() calls, protect from no HOME …
nbriggs 5164fef
Eliminate strcpy/strncat in favor of snprintf()
nbriggs 74cea17
Eliminate strcpy in favor of memcpy into a Lisp string
nbriggs cba5dd6
Merge branch 'master' into nhb-pcap-ethernet
nbriggs 4558c8b
Fixes inverted sense of check for access OK on user .Xdefaults file
nbriggs ce4f791
Ensure captured packet is complete, and of usable size.
nbriggs 10724d0
Really force 64-bit arithmetic for periodic timer count on all archit…
nbriggs f8d1f4c
Frees compiled packet match filter on error return from init_pcap
nbriggs 4f7be29
Updates comments on how the interface name/address finding should be …
nbriggs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.