Skip to content

Support passing cluster_name as an explicit sandbox create arg #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Harold-lkk merged 1 commit into from
Jul 29, 2026
+3 −0
Merged

Support passing cluster_name as an explicit sandbox create arg #1975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions xtuner/v1/rl/agent_loop/sandbox_agent_loop/sandbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,6 +939,8 @@ async def _acquire_ready(self, spec: SandboxSpec, *, record: StageRecord | None
record.metadata["sandbox_create_attempts"] = attempt
try:
create_kwargs: dict[str, Any] = {}
if spec.cluster_name:
create_kwargs["cluster_name"] = spec.cluster_name
if spec.key:
create_kwargs["key"] = spec.key
if spec.env_vars:
Expand Down
1 change: 1 addition & 0 deletions xtuner/v1/rl/agent_loop/sandbox_agent_loop/schemas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ class SandboxSpec(BaseModel):
env_vars: dict[str, str] = Field(default_factory=dict)
resources: dict[str, Any] = Field(default_factory=dict)
key: str | None = None
cluster_name: str | None = None


class AgentSpec(BaseModel):
Expand Down
Loading