[CG] Fix cg_fovViewModel when cg_fovAspectAdjust#1345
Open
SomaZ wants to merge 1 commit into
Open
Conversation
The scaling factor should always be the same and based on the difference of the set fov and the wanted fov. All fov effects can work properly now and arent overwritten and it works with aspect correction.
Member
|
Doesn't this break cases where cg_fov is overridden |
Member
Author
This is exactly what it actually fixes. Currently, cases with overwritten fov will still force the exact defined weapon fov. This is not desirable though as you want the effect to apply to the weapon as well. |
Member
Author
|
Running cg_fov 100 and cg_fovViewModel 0, using force speed: running cg_fov 100 and cg_fovViewModel 101 with fixed code: running cg_fov 100 and cg_fovViewModel 101 with broken code: now broken code with disabled cg_fovViewModelAdjust to get the model at least in sight: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scaling factor should always be the same and based on the difference of the set fov and the wanted fov. All fov effects can work properly now and arent overwritten and it works with aspect correction.