Skip to content

compare_wef.py is overly complex and could benifit from OO refactoring #5

Description

@JPvRiel

The main compare_wef.py was naively written as flat script with a few methods where I grossly underestimated the complexity of associating windows XPath queries with windows event metadata.

The resulting script is messy, hard to maintain or debug sprawl of global vars and data acted on by functions and this has resulted in undesirable coupling between the globals and functions.

Now that I better understand the complexity and it's become a not-trivial first cut/attempt script, it could be refactored using classes to create better cohesion to abstract data characteristics with classes, and the classes should provide methods for parsing, associating and comparing.

This will hopefully also untangle all the lose coupling caused by ad-hoc functions acting on globals and reduce the complexity of debugging.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions