Feat: Syntax multiple expr stmt brackets#485
Draft
JSAbrahams wants to merge 44 commits intodevelopfrom
Draft
Conversation
JSAbrahams
added
documentation
JSAbrahams
force-pushed
the
feat-syntax-multiple-exp-stmt-brackets
branch
from
97f60ee to
b72b4f1
Compare
Blocks are now a litertal 'list of statements'. This means we use square instead of curly brackets to denote them.
JSAbrahams
force-pushed
the
feat-syntax-multiple-exp-stmt-brackets
branch
from
b72b4f1 to
713b458
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #485 +/- ##
===========================================
- Coverage 89.33% 88.51% -0.82%
===========================================
Files 105 105
Lines 15536 15377 -159
===========================================
- Hits 13879 13611 -268
- Misses 1657 1766 +109
🚀 New features to boost your workflow:
|
Also cleanup language spec a bit
I think this terminology fits better what we are trying to achieve.
These tests are ignored, the intention is that: 1) We can parse all of the examples in the README 2) We can type check a subset of the examples in README. Examples which we cannot check should throw check, not parse error.
I think this clashes with the language philosophy. Instead, we favour having this be part of the standard lib
The goal now is to make all tests pass. If a certain feature is not yet supported as of yet, an appropriate type error must be thrown. It is assumed that the parser can be rewritten in one go.
In case class definition is only one line
May want a more structural approach
No assign required. Additionally, update some tests for imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
Summary
Added Tests