fix: open tree_state in binary mode to fix resume on DL exercises - #297
Open
SomeshG1151 wants to merge 1 commit into
Open
fix: open tree_state in binary mode to fix resume on DL exercises#297SomeshG1151 wants to merge 1 commit into
SomeshG1151 wants to merge 1 commit into
Conversation
Handler.on_modified opened the watched file in text mode ('r'), causing
UnicodeDecodeError on binary DL exercise state files. The exception
crashed the watchdog's event thread silently, preventing any further
update_callback calls and breaking Resume for the rest of the session.
Fix: read in binary mode ('rb'), guard against transient OSError,
decode with errors='replace' so downstream consumers still receive str.
Also create the blank sentinel file in binary mode for consistency.
Fixes: JdeRobot/RoboticsAcademy#3926
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Handler.on_modifiedinlibs/file_watchdog.pyopened the watched filein text mode (
"r"). DL exercises write binary data to/tmp/tree_state,causing a
UnicodeDecodeErrorthat silently crashes the watchdog's eventthread. Once crashed, no further
update_callbackcalls fire, so thefrontend never receives state updates and Resume appears permanently broken.
Fix
"rb")OSError(e.g. file deleted between event and read)errors="replace"so downstream consumers still receivestrRelated
Fixes JdeRobot/RoboticsAcademy#3926