Repository navigation
fix(sidebar): style /cmd-settings like the host's list dialogs - #21
Merged
Merged
Conversation
The focused row drew title and value in the same accent over a tinted band. Native pickers use a primary title with a secondary value over background.action.primary.focused, so match that, along with the list insets and the large dialog size.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
JeffreyJYZ
approved these changes
Nov 14, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restyles the
/cmd-settingsdialog to match opencode's own list dialogs.Why
The first version read every token from the
dialogsurface and drew both the title and the value of the focused row in the accent colour, over an accent band, with a fallback band made from the accent at 25 percent alpha. That reads as one saturated block, and it is not how the host draws a selected row.ui/dialog-select.tsxin the host, which is what every native picker uses, draws a selected row as a primary-coloured title with a secondary-coloured value overbackground.action.primary.focused, at insets of five and six cells with a one-cell gap.Changes
text.action.primary.focused, value intext.action.secondary.focused, band frombackground.action.primary.focused, falling back tobackground.raised.baseinstead of a tinted accent.DIALOG_LIST_INSET: five left, six right, one-cell gap.dialog.set({ size: "large" })on mount, which is what native list dialogs do; the default size wrapped the description into a ragged block.Verification
bun checkclean,bun test263 pass,bun run buildclean, anddist/tui.jscarries the new dialog.