[Bug 379660] Collapse template arguments in flamegraph using checkbox - #50
[Bug 379660] Collapse template arguments in flamegraph using checkbox#50aravindev wants to merge 2 commits into
Conversation
|
@SamSaffron @iamsergio @krf @milianw Could one of you assign a reviewer? If this is no longer of interest, feel free to close this PR 😄 |
|
Sorry for the delay, I'll have a look now |
milianw
left a comment
There was a problem hiding this comment.
So, this code is potentially a first step but I think it should be closer to the approach we use in hotspot - see e.g.:
https://github.com/KDAB/hotspot/blob/master/src/util.cpp#L135
generally, we would collapse these everywhere - not just in the flamegraph. the same logic should be used in the tables, and we don't want to do the collapse all the time for view purposes only
Thanks for the pointers. I will update the PR and ping you again! |
This PR is a duplicate of #34 but addresses all the comments since it has been dormant for a while.
I have created a checkbox that can be used to toggle template elision such that the template arguments can optionally be collapsed. This feature is disabled by default.
@milianw Since you were the original reviewer, could you take a look?