Repository navigation
Conversation
Persist and compare process start identities on macOS, Windows, Linux, and Android so PID reuse cannot strand or steal the wallet mutation lock. Reject identity-less records on every platform and use timing-safe comparisons for lock ownership tokens.
|
ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing |
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up for nansen-ai#763. The wallet mutation lock now records and verifies process-start identity on macOS, Windows, Linux, and Android instead of accepting PID-only liveness outside Linux. Identity-less owner and recovery records are rejected on every platform, so PID reuse cannot repeatedly strand wallet mutations. Lock ownership tokens are also compared with
crypto.timingSafeEqual.Changes
src/wallet.js: collect stable process-start identities from procfs, macOSps, or Windows PowerShell; fail closed when a live process identity cannot be verified; require identity in every lock record; compare lock tokens timing-safely.src/__tests__/wallet-concurrency.test.js: run identity-less-record regressions on every platform and extend PID-reuse coverage beyond Linux.Verification
npm run lint— passed.git diff --check— passed.eed52e66: Android deniesfs.linkSyncwithEACCES. GitHub's supported Linux CI exercises those tests.This PR targets
Kewe63:fix/wallet-mutation-lock; merging it updates the head branch of nansen-ai#763.