Repository navigation
Move vkCreateDevice lock into loader_layer_create_device - #2054
Merged
charles-lunarg merged 1 commit intoOct 11, 2026
Merged
Conversation
|
CI Vulkan-Loader build queued with queue ID 152482. |
|
CI Vulkan-Loader build queued with queue ID 152499. |
|
CI Vulkan-Loader build # 3813 running. |
|
CI Vulkan-Loader build # 3813 passed. |
charles-lunarg
force-pushed
the
move_create_device_lock
branch
from
October 11, 2026 05:50
39e2f51 to
74d53e3
Compare
|
CI Vulkan-Loader build queued with queue ID 152585. |
|
CI Vulkan-Loader build queued with queue ID 152602. |
charles-lunarg
force-pushed
the
move_create_device_lock
branch
from
October 11, 2026 05:54
74d53e3 to
c685d27
Compare
|
CI Vulkan-Loader build queued with queue ID 152603. |
|
CI Vulkan-Loader build # 3816 running. |
|
CI Vulkan-Loader build queued with queue ID 152639. |
|
CI Vulkan-Loader build # 3817 running. |
This allows layers that are calling loader_layer_create_device and loader_layer_destroy to be synchronized correctly. Added a threading test that catches the issue when the changes aren't present. Required minor refactoring in the test_layer to work - specifically moving the next_vkGetDeviceProcAddr into the Device struct.
charles-lunarg
force-pushed
the
move_create_device_lock
branch
from
October 11, 2026 06:04
c685d27 to
e08244c
Compare
|
CI Vulkan-Loader build queued with queue ID 152658. |
|
CI Vulkan-Loader build # 3818 running. |
|
CI Vulkan-Loader build queued with queue ID 152677. |
|
CI Vulkan-Loader build # 3819 running. |
|
CI Vulkan-Loader build # 3819 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows layers that are calling loader_layer_create_device directly to be synchronized correctly.