Open
Conversation
|
|
Contributor
|
Rebased on #3936 to fix CI error. |
Author
|
Updated to fix a new test added in ba16404 that was failing. |
Implement the change in issue 2708 so `noContraction` is set for `dot()` in the AST. Translate `EOpDot` using `createBinaryOperation()`, which handles setting the `NoContraction` decoration unlike `createMiscOperation()`.
arcady-lunarg
force-pushed
the
fix-2708
branch
from
3f48303 to
264e892
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the change in issue #2708 so
noContractionis set fordot()in the AST.Translate
EOpDotusingcreateBinaryOperation(), which handles setting theNoContractiondecoration unlikecreateMiscOperation().Fixes #2708.