Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. WalkthroughThe core package constrains Together to versions from 1.5.35 up to, but excluding, 2, and removes its git source override. ChangesCore dependency declarations
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The change switches the dependency to the compatible official PyPI release and updates the lockfile; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Description checkExplanation The description clearly explains the problem, rationale, dependency changes, compatibility constraint, verification steps, and test results. It does not use every template heading and does not include a Related Issues entry or explicit CLA confirmation, but the required change and validation details are substantially complete. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📊 Coverage ReportOverall Coverage: 92% Diff: origin/main...HEADNo lines with coverage information in this diff.
|
The recurring Dependabot 'uv in /. for mcp' updates were failing to resolve: mcp[cli] >=1.11 requires typer>=0.16.0, but together was pinned to the scosman/together-python fork (v1.5.0), which caps typer at <0.16. Any mcp bump was therefore unsatisfiable. The fork existed only to make pyarrow an optional/runtime import (togethercomputer/together-python#276, by scosman). That change was merged upstream on 2025-06-02, and official together has since also relaxed its typer cap to <0.20. So the official 1.5.x line now gives us both fixes: - pyarrow is optional (together no longer drags it in) - typer <0.20 allows typer>=0.16, unblocking mcp[cli] upgrades Changes: - together: git fork -> 'together>=1.5.35,<2' from PyPI - remove the [tool.uv.sources] git override - keep mcp[cli] as-is (no longer need to touch it) Pinned <2 to stay on the API-compatible 1.5.x line; together 2.x drops typer for cyclopts and changes APIs the finetune adapter relies on. Verified: uv sync OK, together SDK imports OK, and 'uv lock --upgrade-package mcp' now resolves cleanly (1.10.1 -> 1.28.1, typer -> 0.19.2). Tests pass: test_together_finetune, mcp tool suites (140 passed, 5 skipped).
0efdc6d to
18a5342
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Problem
The Dependabot Updates job on
mainkeeps failing (uv in /. for mcp - Update) — the only red CI onmain. It can't resolve a bump ofmcp:Why the fork existed — and why it's no longer needed
togetherwas pinned to thescosman/together-pythonfork. That fork existed solely to makepyarrowan optional/runtime import (pyarrowis ~100MB and breaks on Intel Macs) — togethercomputer/together-python#276, authored by scosman.That PR was merged upstream on 2025-06-02. Since then official
togetherhas also relaxed itstypercap. The latest 1.5.x release (v1.5.35) has both:pyarrow = { optional = true }— the fork's whole reason to exist, now upstreamtyper = ">=0.9,<0.20"— allowstyper>=0.16, somcp[cli]can upgradeSo pointing at official
togetherfixes the Dependabot conflict without touching themcpdep at all.Changes
libs/core/pyproject.toml:together→together>=1.5.35,<2(from PyPI)[tool.uv.sources]git override fortogethermcp[cli]left unchangedPinned
<2to stay on the API-compatible 1.5.x line —together2.x dropstyperforcycloptsand changes APIs the fine-tune adapter (together_finetune.py) relies on. That migration is a separate follow-up.Verification
togethernow resolves to 1.5.35 from PyPI (no git);pyarrowin the lock now comes only fromlancedb/pylance, nottogether.uv syncOK;Together,FilePurpose,FinetuneJobStatusall import fine on 1.5.35.uv lock --upgrade-package mcpnow resolves cleanly (mcp1.10.1 → 1.28.1,typer→ 0.19.2) — Dependabot will no longer fail.test_together_finetune.py+ mcp tool suites — 140 passed, 5 skipped.Note
together1.x prints a deprecation banner ("maintained until January 2026"). Staying on 1.5.x is the safe fix now; migrating the fine-tune adapter totogether2.x is worth a follow-up.