Skip to content

feat(mobile): wrap detail sheet mono text by default - #5073

Merged
iscekic merged 7 commits into
mainfrom
detail-sheet-ux-21a2
Aug 6, 2026
Merged

iscekic merged 7 commits into
mainfrom
detail-sheet-ux-21a2

Conversation

@iscekic

@iscekic iscekic commented Aug 5, 2026 •

Copy link
Copy Markdown
Collaborator

The user now sees long tool text wrapped by default in the mobile detail sheet. The user can select Scroll for horizontal panning, and closing the sheet resets Wrap.

The product manager gets a content-driven Text display control. The control appears only when the sheet contains a mono text block, so empty and command-only views have no redundant control.

The maintainer gets a React context carrying display mode and mono-block presence. The sheet owns mode state and resets it when visibility becomes false; the existing scroll branch remains intact, while wrap mode preserves native selectable text for sheet content and plain Text for transcript content. Mounted and pure tests cover the branches, accessibility, presence, stream updates, and host close lifecycle.

Human steps: no step is needed before or after merge.

E2E: bot-e2e — iOS runtime verification passed on the live mobile stack.

Visual Changes:

@iscekic iscekic self-assigned this Aug 5, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of the latest commit (test-assertion update observing read errors through SelectableText/TextInput value) confirms it matches the implementation exactly, and the previously reviewed wrap-by-default mono text feature remains clean with thorough test coverage and no memory-leak vectors.

Files Reviewed (8 files)
  • apps/mobile/src/components/agents/mono-scroll-block-model.ts
  • apps/mobile/src/components/agents/mono-scroll-block.tsx
  • apps/mobile/src/components/agents/part-detail-sheet.tsx
  • apps/mobile/src/components/agents/mono-scroll-block.test.ts
  • apps/mobile/src/components/agents/mono-scroll-block.mounted.test.tsx
  • apps/mobile/src/components/agents/part-detail-sheet.mounted.test.tsx
  • apps/mobile/src/components/agents/part-detail-sheet-host.mounted.test.tsx
  • apps/mobile/src/components/agents/tool-cards/tool-card-output-cap.test.ts
Previous Review Summary (commit 6a13369)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 6a13369)

Status: No Issues Found | Recommendation: Merge

Executive Summary

The wrap-by-default mono text feature for the mobile detail sheet is implemented cleanly — context-driven display mode, presence-tracked control visibility, and a correct close-reset lifecycle — with thorough mounted and pure test coverage and no memory-leak vectors (the only effect registers presence with a proper cleanup).

Files Reviewed (7 files)
  • apps/mobile/src/components/agents/mono-scroll-block-model.ts
  • apps/mobile/src/components/agents/mono-scroll-block.tsx
  • apps/mobile/src/components/agents/part-detail-sheet.tsx
  • apps/mobile/src/components/agents/mono-scroll-block.test.ts
  • apps/mobile/src/components/agents/mono-scroll-block.mounted.test.tsx
  • apps/mobile/src/components/agents/part-detail-sheet.mounted.test.tsx
  • apps/mobile/src/components/agents/part-detail-sheet-host.mounted.test.tsx

Reviewed by kimi-k3 · Input: 32.6K · Output: 5.3K · Cached: 316K

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added the human-ready The PR is ready for human review. label Aug 5, 2026
@iscekic
iscekic merged commit fc152c1 into main Aug 6, 2026
21 checks passed
@iscekic
iscekic deleted the detail-sheet-ux-21a2 branch August 6, 2026 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants