Repository navigation
feat(mobile): wrap detail sheet mono text by default - #5073
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the latest commit (test-assertion update observing read errors through Files Reviewed (8 files)
Previous Review Summary (commit 6a13369)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 6a13369)Status: No Issues Found | Recommendation: Merge Executive SummaryThe wrap-by-default mono text feature for the mobile detail sheet is implemented cleanly — context-driven display mode, presence-tracked control visibility, and a correct close-reset lifecycle — with thorough mounted and pure test coverage and no memory-leak vectors (the only effect registers presence with a proper cleanup). Files Reviewed (7 files)
Reviewed by kimi-k3 · Input: 32.6K · Output: 5.3K · Cached: 316K Review guidance: REVIEW.md from base branch |
The user now sees long tool text wrapped by default in the mobile detail sheet. The user can select Scroll for horizontal panning, and closing the sheet resets Wrap.
The product manager gets a content-driven Text display control. The control appears only when the sheet contains a mono text block, so empty and command-only views have no redundant control.
The maintainer gets a React context carrying display mode and mono-block presence. The sheet owns mode state and resets it when visibility becomes false; the existing scroll branch remains intact, while wrap mode preserves native selectable text for sheet content and plain Text for transcript content. Mounted and pure tests cover the branches, accessibility, presence, stream updates, and host close lifecycle.
Human steps: no step is needed before or after merge.
E2E: bot-e2e — iOS runtime verification passed on the live mobile stack.
Visual Changes: