Skip to content

fix(mobile): simplify tool rich renderers - #5074

Merged
iscekic merged 7 commits into
mainfrom
tool-rich-renderers-bc52
Aug 6, 2026
Merged

iscekic merged 7 commits into
mainfrom
tool-rich-renderers-bc52

Conversation

@iscekic

@iscekic iscekic commented Aug 5, 2026 •

Copy link
Copy Markdown
Collaborator

Users now see one image preview or file chip per tool part, without duplicated cached content. Markdown reads render the complete document directly in the scrollable detail sheet, without a duplicate full-reader action.

The mobile tool detail keeps full-screen image viewing, file sharing, selectable markdown, table access, and diff meaning. Error states and accessibility labels remain explicit.

The implementation follows the existing part-id image cache: render the first attachment, mount image viewers on demand, share markdown link interaction props, and add focused mounted and pure tests. The current main branch supplies the full markdown body design. No backend or dependency changes were made.

Human steps: none before or after merge.

Visual Changes: N/A.

E2E: bot-e2e — iOS verification covers image, direct markdown body plus table, and diff flows.

@iscekic iscekic self-assigned this Aug 5, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of the new accessibility commit (diff row accessible exposure in diff-line.tsx plus its mounted test) found no correctness, security, or memory-leak issues; the fix is minimal, matches the label builder contract, and follows existing repo test patterns.

Files Reviewed (10 files)
  • apps/mobile/src/components/agents/markdown-renderer.test.ts
  • apps/mobile/src/components/agents/markdown-renderer.ts
  • apps/mobile/src/components/agents/markdown-table.test.ts
  • apps/mobile/src/components/agents/tool-card-file-attachments.mounted.test.tsx
  • apps/mobile/src/components/agents/tool-card-file-attachments.tsx
  • apps/mobile/src/components/agents/tool-card-image-attachments.mounted.test.tsx
  • apps/mobile/src/components/agents/tool-card-image-attachments.tsx
  • apps/mobile/src/components/agents/tool-cards/tool-card-output-cap.test.ts
  • apps/mobile/src/components/agents/tool-diff-preview.test.ts
  • apps/mobile/src/components/pr-review/diff/diff-line.tsx
Previous Review Summary (commit fadc706)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit fadc706)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (8 files)
  • apps/mobile/src/components/agents/markdown-renderer.test.ts
  • apps/mobile/src/components/agents/markdown-renderer.ts
  • apps/mobile/src/components/agents/markdown-table.test.ts
  • apps/mobile/src/components/agents/tool-card-file-attachments.mounted.test.tsx
  • apps/mobile/src/components/agents/tool-card-file-attachments.tsx
  • apps/mobile/src/components/agents/tool-card-image-attachments.mounted.test.tsx
  • apps/mobile/src/components/agents/tool-card-image-attachments.tsx
  • apps/mobile/src/components/agents/tool-cards/tool-card-output-cap.test.ts

Reviewed by kimi-k3 · Input: 70.9K · Output: 11.5K · Cached: 622.6K

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added the human-ready The PR is ready for human review. label Aug 6, 2026
@iscekic
iscekic enabled auto-merge (squash) August 6, 2026 08:50
@iscekic
iscekic merged commit 8d3c6cc into main Aug 6, 2026
19 checks passed
@iscekic
iscekic deleted the tool-rich-renderers-bc52 branch August 6, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants