Repository navigation
fix(mobile): stop search indicator CLS and group preferences - #5082
Merged
Merged
Conversation
Move the Agents search spinner into the search input. The separate "Searching…" row appeared below the input and pushed the list down. The spinner now swaps with the search icon in a fixed-size slot. Move the Appearance control and the Notifications row from the Profile screen into the Preferences screen.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Reviewed all 4 changed files at 26df465: the search spinner now swaps with the search icon inside a fixed 18px slot (eliminating the layout shift as described), and the Appearance/Notifications sections were moved verbatim from Profile to Preferences with all imports, prop signatures, hooks, and the notifications route verified against their definitions. No memory leaks introduced — no new subscriptions, timers, or listeners; Files Reviewed (4 files)
Reviewed by kimi-k3 · Input: 46.2K · Output: 6.7K · Cached: 232.4K Review guidance: REVIEW.md from base branch |
iscekic
enabled auto-merge (squash)
August 6, 2026 09:22
jeanduplessis
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small mobile UI changes.
Session list search indicator
Profile preferences
Test
pnpm format && pnpm typecheck && pnpm lint && pnpm check:unused && pnpm testpass inapps/mobile. 3695 tests pass.