Skip to content

fix(mobile): stop search indicator CLS and group preferences - #5082

Merged
iscekic merged 1 commit into
mainfrom
profile-prefs-search-9c31
Aug 6, 2026
Merged

iscekic merged 1 commit into
mainfrom
profile-prefs-search-9c31

Conversation

@iscekic

@iscekic iscekic commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Two small mobile UI changes.

Session list search indicator

  • The "Searching…" row rendered below the search input and pushed the list down. That caused cumulative layout shift (CLS).
  • The spinner now replaces the search icon inside the input, in a fixed-size 18px slot. The row never reflows.

Profile preferences

  • Moved the Appearance segmented control and the Notifications row from the Profile screen into the Preferences screen.
  • Updated the Profile "Preferences" subtitle to name the four groups.

Test

pnpm format && pnpm typecheck && pnpm lint && pnpm check:unused && pnpm test pass in apps/mobile. 3695 tests pass.

Move the Agents search spinner into the search input. The separate
"Searching…" row appeared below the input and pushed the list down.
The spinner now swaps with the search icon in a fixed-size slot.

Move the Appearance control and the Notifications row from the Profile
screen into the Preferences screen.
@iscekic iscekic self-assigned this Aug 6, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Reviewed all 4 changed files at 26df465: the search spinner now swaps with the search icon inside a fixed 18px slot (eliminating the layout shift as described), and the Appearance/Notifications sections were moved verbatim from Profile to Preferences with all imports, prop signatures, hooks, and the notifications route verified against their definitions. No memory leaks introduced — no new subscriptions, timers, or listeners; useThemePreference uses useSyncExternalStore with React-managed cleanup and is relocated, not duplicated.

Files Reviewed (4 files)
  • apps/mobile/src/components/agents/session-list-search-busy.ts
  • apps/mobile/src/components/agents/session-list-search-header.tsx
  • apps/mobile/src/components/preferences-screen.tsx
  • apps/mobile/src/components/profile-screen.tsx

Reviewed by kimi-k3 · Input: 46.2K · Output: 6.7K · Cached: 232.4K

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic enabled auto-merge (squash) August 6, 2026 09:22
@iscekic
iscekic merged commit ba93040 into main Aug 6, 2026
21 checks passed
@iscekic
iscekic deleted the profile-prefs-search-9c31 branch August 6, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants