Skip to content

fix(extension): preserve browser chat runs - #5113

Merged
iscekic merged 6 commits into
mainfrom
ext-browser-chat-5688
Aug 7, 2026
Merged

iscekic merged 6 commits into
mainfrom
ext-browser-chat-5688

Conversation

@iscekic

@iscekic iscekic commented Aug 6, 2026 •

Copy link
Copy Markdown
Collaborator

Users can keep a browser chat run active while they open the Agents tab, queue the next message, and see the conversation model while the catalog loads.

Product behavior now preserves streaming output across the mode switch, sends queued text after the active turn, drops queued text on Stop, and locks model controls during a run.

The panel remains mounted while hidden, queue state lives per conversation, and the gateway paths validate the stored model against the loaded catalog. Focused Vitest and Chrome and Firefox extension checks cover the new behavior.

Human steps: none.

Visual Changes: N/A.

E2E: bot-e2e. Chrome continuity and model-loading scenarios passed 8/8, Firefox Selenium passed 35/35, and the repaired queue/model re-verification passed.

@iscekic iscekic self-assigned this Aug 6, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental re-review of the new commit (5ef540c, fix(extension): rerun queued message drain) confirms the previously reported warning is fixed: the queued-message drain effect in agent-chat-panel.tsx now lists conversationStore in its dependencies, so it re-runs after the model-repair effect rewrites a stale stored model and the queued message drains; the clear-before-send guard still prevents re-queue loops, and no new issues were found in the changed lines.

Files Reviewed (14 files)

This pass re-reviewed the incremental change in apps/extension/entrypoints/sidepanel/agent-chat-panel.tsx; all other files were reviewed in earlier passes and are unchanged since.

  • apps/extension/entrypoints/sidepanel/agent-chat-atoms.ts
  • apps/extension/entrypoints/sidepanel/agent-chat-panel.tsx
  • apps/extension/entrypoints/sidepanel/agent-footer-controls.tsx
  • apps/extension/entrypoints/sidepanel/agent-message-queue.test.ts
  • apps/extension/entrypoints/sidepanel/agent-message-queue.ts
  • apps/extension/entrypoints/sidepanel/auth-views.tsx
  • apps/extension/entrypoints/sidepanel/message-composer.test.tsx
  • apps/extension/entrypoints/sidepanel/message-composer.tsx
  • apps/extension/entrypoints/sidepanel/model-picker.test.tsx
  • apps/extension/entrypoints/sidepanel/model-picker.tsx
  • apps/extension/src/shared/agent-chat-atoms.test.ts
  • apps/extension/tests/e2e/browser-run-continuity.test.ts
  • apps/extension/tests/e2e/firefox-selenium-e2e.ts
  • apps/extension/tests/e2e/model-loading.test.ts
Previous Review Summaries (2 snapshots, latest commit ad7b639)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit ad7b639)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The queued-message drain effect in agent-chat-panel.tsx still never re-runs after the model-repair effect rewrites a stale stored model, so a queued message can remain stuck unsent after a mid-run credit-account switch; the new commit only renames the effect in a code comment and does not address the defect.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/extension/entrypoints/sidepanel/agent-chat-panel.tsx 1030 Drain-effect deps omit conversationStore: after the model-repair effect repairs a stale model, the drain effect never re-runs (repair changes the store, not modelOptions), leaving the queued message stuck; background conversations with stale models are never repaired at all
Files Reviewed (14 files)
  • apps/extension/entrypoints/sidepanel/agent-chat-atoms.ts
  • apps/extension/entrypoints/sidepanel/agent-chat-panel.tsx - 1 issue
  • apps/extension/entrypoints/sidepanel/agent-footer-controls.tsx
  • apps/extension/entrypoints/sidepanel/agent-message-queue.test.ts
  • apps/extension/entrypoints/sidepanel/agent-message-queue.ts
  • apps/extension/entrypoints/sidepanel/auth-views.tsx
  • apps/extension/entrypoints/sidepanel/message-composer.test.tsx
  • apps/extension/entrypoints/sidepanel/message-composer.tsx
  • apps/extension/entrypoints/sidepanel/model-picker.test.tsx
  • apps/extension/entrypoints/sidepanel/model-picker.tsx
  • apps/extension/src/shared/agent-chat-atoms.test.ts
  • apps/extension/tests/e2e/browser-run-continuity.test.ts
  • apps/extension/tests/e2e/firefox-selenium-e2e.ts
  • apps/extension/tests/e2e/model-loading.test.ts

Fix these issues in Kilo Cloud

Previous review (commit b0f210a)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

The queued-message drain effect in agent-chat-panel.tsx never re-runs after the model-repair effect rewrites a stale stored model, so a queued message can remain stuck unsent after a mid-run credit-account switch.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0
Issue Details (click to expand)

WARNING

File Line Issue
apps/extension/entrypoints/sidepanel/agent-chat-panel.tsx 1030 Drain-effect deps omit conversationStore: after the seed effect repairs a stale model, the drain effect never re-runs (repair changes the store, not modelOptions), leaving the queued message stuck; background conversations with stale models are never repaired at all
Files Reviewed (14 files)
  • apps/extension/entrypoints/sidepanel/agent-chat-atoms.ts
  • apps/extension/entrypoints/sidepanel/agent-chat-panel.tsx - 1 issue
  • apps/extension/entrypoints/sidepanel/agent-footer-controls.tsx
  • apps/extension/entrypoints/sidepanel/agent-message-queue.test.ts
  • apps/extension/entrypoints/sidepanel/agent-message-queue.ts
  • apps/extension/entrypoints/sidepanel/auth-views.tsx
  • apps/extension/entrypoints/sidepanel/message-composer.test.tsx
  • apps/extension/entrypoints/sidepanel/message-composer.tsx
  • apps/extension/entrypoints/sidepanel/model-picker.test.tsx
  • apps/extension/entrypoints/sidepanel/model-picker.tsx
  • apps/extension/src/shared/agent-chat-atoms.test.ts
  • apps/extension/tests/e2e/browser-run-continuity.test.ts
  • apps/extension/tests/e2e/firefox-selenium-e2e.ts
  • apps/extension/tests/e2e/model-loading.test.ts

Fix these issues in Kilo Cloud


Reviewed by kimi-k3 · Input: 56.8K · Output: 10.1K · Cached: 591.5K

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added the human-ready The PR is ready for human review. label Aug 6, 2026
@iscekic
iscekic enabled auto-merge (squash) August 7, 2026 11:30
@iscekic
iscekic merged commit 3bdd5b0 into main Aug 7, 2026
15 of 17 checks passed
@iscekic
iscekic deleted the ext-browser-chat-5688 branch August 7, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants