Repository navigation
feat(slack): encrypt bot tokens at rest in Chat SDK state - #5131
Merged
Merged
Conversation
Wire SLACK_ENCRYPTION_KEY into createSlackAdapter so the Slack bot token is stored AES-256-GCM encrypted in the Chat SDK state store instead of plaintext. The key is passed explicitly rather than relying on the adapter's env fallback. It is coerced to undefined when empty because the adapter resolves the option with `??`, so an empty string would both suppress that fallback and silently disable encryption. Reads remain backward compatible with existing plaintext entries; a follow-up backfill will rewrite them.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryWiring Files Reviewed (5 files)
Reviewed by kimi-k3 · Input: 43.5K · Output: 11.7K · Cached: 586.7K Review guidance: REVIEW.md from base branch |
jeanduplessis
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires
SLACK_ENCRYPTION_KEYintocreateSlackAdapterso Slack bot tokens are stored AES-256-GCM encrypted in the Chat SDK state store instead of plaintext.Reads stay backward compatible with existing plaintext entries, so a follow-up backfill is needed to rewrite them.