Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-apps.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: build-apps

Check warning on line 1 in .github/workflows/build-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

excessive-permissions

build-apps.yml:1: overly broad permissions: default permissions used due to no permissions: block

on:
pull_request:
Expand All @@ -18,19 +18,19 @@
cancel-in-progress: true

jobs:
build-wasm:

Check warning on line 21 in .github/workflows/build-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

excessive-permissions

build-apps.yml:21: overly broad permissions: default permissions used due to no permissions: block
uses: ./.github/workflows/build-wasm.yml

prepare-files:

Check warning on line 24 in .github/workflows/build-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

excessive-permissions

build-apps.yml:24: overly broad permissions: default permissions used due to no permissions: block
needs: [build-wasm]
runs-on: namespace-profile-ubuntu-8-cores
outputs:
version: ${{ steps.export_version.outputs.version }}
notes: ${{ steps.export_notes.outputs.notes }}
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1

Check warning on line 31 in .github/workflows/build-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

artipacked

build-apps.yml:31: credential persistence through GitHub Actions artifacts: does not set persist-credentials: false

- uses: actions/setup-node@v6.4.0

Check failure on line 33 in .github/workflows/build-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

cache-poisoning

build-apps.yml:33: runtime artifacts potentially vulnerable to a cache poisoning attack: this step
with:
node-version-file: .nvmrc
cache: npm
Expand Down Expand Up @@ -98,7 +98,7 @@
run: echo "notes=`cat release-notes.md`" >> "$GITHUB_OUTPUT"


build-apps:

Check warning on line 101 in .github/workflows/build-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

excessive-permissions

build-apps.yml:101: overly broad permissions: default permissions used due to no permissions: block
needs: [prepare-files]
strategy:
fail-fast: false
Expand All @@ -115,7 +115,7 @@
env:
VERSION_NO_V: ${{ needs.prepare-files.outputs.version }}
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1

Check warning on line 118 in .github/workflows/build-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

artipacked

build-apps.yml:118: credential persistence through GitHub Actions artifacts: does not set persist-credentials: false

- uses: actions/download-artifact@v8
with:
Expand Down Expand Up @@ -148,7 +148,7 @@
cp -r prepared-ts-rs-bindings/* rust/kcl-lib/bindings/

- name: Sync node version and setup cache
uses: actions/setup-node@v6.4.0

Check failure on line 151 in .github/workflows/build-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

cache-poisoning

build-apps.yml:151: runtime artifacts potentially vulnerable to a cache poisoning attack: this step
with:
node-version-file: .nvmrc
cache: npm # Set this to npm, npm or pnpm.
Expand Down Expand Up @@ -230,7 +230,7 @@
VERSION: ${{ format('v{0}', needs.prepare-files.outputs.version) }}
needs: [prepare-files, build-apps]
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1

Check warning on line 233 in .github/workflows/build-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

artipacked

build-apps.yml:233: credential persistence through GitHub Actions artifacts: does not set persist-credentials: false

- uses: actions/download-artifact@v8
with:
Expand Down Expand Up @@ -279,9 +279,9 @@
--arg version "${VERSION}" \
--arg pub_date "${PUB_DATE}" \
--arg notes "${NOTES}" \
--arg mac_universal_url "$RELEASE_DIR/${{ env.URL_CODED_NAME }}-${VERSION_NO_V}-universal-mac.dmg" \

Check warning on line 282 in .github/workflows/build-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

template-injection

build-apps.yml:282: code injection via template expansion: may expand into attacker-controllable code
--arg windows_universal_url "$RELEASE_DIR/${{ env.URL_CODED_NAME }}-${VERSION_NO_V}-universal-win.exe" \

Check warning on line 283 in .github/workflows/build-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

template-injection

build-apps.yml:283: code injection via template expansion: may expand into attacker-controllable code
--arg linux_arm64_url "$RELEASE_DIR/${{ env.URL_CODED_NAME }}-${VERSION_NO_V}-arm64-linux.AppImage" \

Check warning on line 284 in .github/workflows/build-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

template-injection

build-apps.yml:284: code injection via template expansion: may expand into attacker-controllable code
--arg linux_x64_url "$RELEASE_DIR/${{ env.URL_CODED_NAME }}-${VERSION_NO_V}-x86_64-linux.AppImage" \
'{
"version": $version,
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-wasm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
build-wasm:
runs-on: namespace-profile-ubuntu-8-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
with:
repository: kittycad/modeling-app # required for 'workflow_call'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cargo-bench.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
# Enabling this results in the following error on GitHub Actions:
# setarch: failed to set personality to x86_64: Operation not permitted
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- name: Use correct Rust toolchain
shell: bash
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cargo-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
name: cargo check
runs-on: namespace-profile-ubuntu-8-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- name: Use correct Rust toolchain
shell: bash
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cargo-clippy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
name: cargo clippy
runs-on: namespace-profile-ubuntu-8-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- uses: taiki-e/install-action@just
- name: Use correct Rust toolchain
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/cargo-fmt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
name: cargo fmt
runs-on: namespace-profile-ubuntu-2-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- name: Use correct Rust toolchain
shell: bash
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/cargo-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

permissions:
contents: read
pull-requests: write

Check failure on line 14 in .github/workflows/cargo-test.yml

View workflow job for this annotation

GitHub Actions / zizmor

excessive-permissions

cargo-test.yml:14: overly broad permissions: pull-requests: write is overly broad at the workflow level

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand All @@ -23,13 +23,13 @@
runs-on: namespace-profile-ubuntu-8-cores
steps:
- uses: runs-on/action@v2.2.0
- uses: actions/create-github-app-token@v3.2.0

Check failure on line 26 in .github/workflows/cargo-test.yml

View workflow job for this annotation

GitHub Actions / zizmor

github-app

cargo-test.yml:26: dangerous use of GitHub App tokens: app token inherits blanket installation permissions
id: app-token
with:
app-id: ${{ secrets.MODELING_APP_GH_APP_ID }}
private-key: ${{ secrets.MODELING_APP_GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}

Check failure on line 31 in .github/workflows/cargo-test.yml

View workflow job for this annotation

GitHub Actions / zizmor

github-app

cargo-test.yml:31: dangerous use of GitHub App tokens: token granted access to all repositories for this owner's app installation
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
with:
token: ${{ steps.app-token.outputs.token }}
- name: Track setup
Expand Down Expand Up @@ -164,13 +164,13 @@
partitionTotal: [3]
steps:
- uses: runs-on/action@v2.2.0
- uses: actions/create-github-app-token@v3.2.0

Check failure on line 167 in .github/workflows/cargo-test.yml

View workflow job for this annotation

GitHub Actions / zizmor

github-app

cargo-test.yml:167: dangerous use of GitHub App tokens: app token inherits blanket installation permissions
id: app-token
with:
app-id: ${{ secrets.MODELING_APP_GH_APP_ID }}
private-key: ${{ secrets.MODELING_APP_GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}

Check failure on line 172 in .github/workflows/cargo-test.yml

View workflow job for this annotation

GitHub Actions / zizmor

github-app

cargo-test.yml:172: dangerous use of GitHub App tokens: token granted access to all repositories for this owner's app installation
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
with:
token: ${{ steps.app-token.outputs.token }}
- name: Use correct Rust toolchain
Expand Down Expand Up @@ -241,7 +241,7 @@
fail-fast: false
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- name: Use correct Rust toolchain
shell: bash
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-kcl-header.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
check-kcl-header:
runs-on: namespace-profile-ubuntu-2-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1

- name: Check KCL files for header comment block and blank line
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codemirror-lang-kcl.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
npm-unit-test:
runs-on: namespace-profile-ubuntu-2-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1

- uses: actions/setup-node@v6.4.0
with:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/e2e-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@
cancel-in-progress: true

permissions:
contents: write

Check failure on line 18 in .github/workflows/e2e-tests.yml

View workflow job for this annotation

GitHub Actions / zizmor

excessive-permissions

e2e-tests.yml:18: overly broad permissions: contents: write is overly broad at the workflow level
pull-requests: write

Check failure on line 19 in .github/workflows/e2e-tests.yml

View workflow job for this annotation

GitHub Actions / zizmor

excessive-permissions

e2e-tests.yml:19: overly broad permissions: pull-requests: write is overly broad at the workflow level
actions: read

jobs:
track-setup:
runs-on: namespace-profile-ubuntu-2-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
with:
repository: kittycad/modeling-app # required for 'workflow_call'

Expand Down Expand Up @@ -75,9 +75,9 @@
with:
app-id: ${{ secrets.MODELING_APP_GH_APP_ID }}
private-key: ${{ secrets.MODELING_APP_GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}

Check failure on line 78 in .github/workflows/e2e-tests.yml

View workflow job for this annotation

GitHub Actions / zizmor

github-app

e2e-tests.yml:78: dangerous use of GitHub App tokens: token granted access to all repositories for this owner's app installation

- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
with:
repository: kittycad/modeling-app # required for 'workflow_call'
token: ${{ steps.app-token.outputs.token }}
Expand Down Expand Up @@ -220,7 +220,7 @@
private-key: ${{ secrets.MODELING_APP_GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}

- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
with:
repository: kittycad/modeling-app # required for 'workflow_call'
token: ${{ steps.app-token.outputs.token }}
Expand Down Expand Up @@ -326,7 +326,7 @@
OS_NAME: ${{ contains(matrix.os, 'ubuntu') && 'ubuntu' || (contains(matrix.os, 'windows') && 'windows' || 'macos') }}

steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
with:
repository: kittycad/modeling-app # required for 'workflow_call'

Expand Down Expand Up @@ -446,7 +446,7 @@
if: github.repository == 'kittycad/modeling-app' && (github.event_name == 'pull_request' || (github.event_name == 'push' && github.ref_name == 'main'))

steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1

- uses: actions/setup-node@v6.4.0
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/generate-machine-api-types.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
generate:
runs-on: namespace-profile-ubuntu-2-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- uses: actions/setup-node@v6.4.0
with:
node-version-file: .nvmrc
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/generate-website-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
name: generate-website-docs
runs-on: namespace-profile-ubuntu-2-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- uses: actions/create-github-app-token@v3.2.0
id: app-token
with:
Expand All @@ -28,7 +28,7 @@ jobs:
private-key: ${{ secrets.MODELING_APP_GH_APP_PRIVATE_KEY }}
owner: ${{ github.repository_owner }}
# Checkout the docs repo since we will want to update the files there.
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
with:
repository: 'kittycad/documentation'
path: 'documentation'
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/kcl-language-server.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v7.0.0
uses: actions/checkout@v7.0.1
- name: Install Node.js
uses: actions/setup-node@v6.4.0
with:
Expand Down Expand Up @@ -105,7 +105,7 @@ jobs:
RA_TARGET: ${{ matrix.target }}
steps:
- name: Checkout repository
uses: actions/checkout@v7.0.0
uses: actions/checkout@v7.0.1
with:
fetch-depth: ${{ env.FETCH_DEPTH }}
- name: Use correct Rust toolchain
Expand Down Expand Up @@ -221,7 +221,7 @@ jobs:
nodejs \
npm
- name: Checkout repository
uses: actions/checkout@v7.0.0
uses: actions/checkout@v7.0.1
with:
fetch-depth: ${{ env.FETCH_DEPTH }}
- name: Use correct Rust toolchain
Expand Down Expand Up @@ -271,7 +271,7 @@ jobs:
- run: echo "TAG=${GITHUB_REF#refs/*/}" >> $GITHUB_ENV
- run: 'echo "TAG: $TAG"'
- name: Checkout repository
uses: actions/checkout@v7.0.0
uses: actions/checkout@v7.0.1
with:
fetch-depth: ${{ env.FETCH_DEPTH }}
- name: Install Nodejs
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/kcl-python-bindings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
name: kcl-python-bindings (linux-x86_64)
runs-on: namespace-profile-ubuntu-8-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- uses: actions/setup-python@v6.3.0
with:
python-version: 3.x
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
- x64
fail-fast: false
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- uses: actions/setup-python@v6.3.0
with:
python-version: 3.x
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:
- aarch64
fail-fast: false
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- uses: actions/setup-python@v6.3.0
with:
python-version: 3.x
Expand All @@ -118,7 +118,7 @@ jobs:
name: kcl-python-bindings (test)
runs-on: namespace-profile-ubuntu-8-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- name: Track setup
run: .github/ci-cd-scripts/track-step.sh
env:
Expand Down Expand Up @@ -161,7 +161,7 @@ jobs:
name: kcl-python-bindings (sdist)
runs-on: namespace-profile-ubuntu-8-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- name: Install the latest version of uv
uses: astral-sh/setup-uv@v8.3.2
- name: Create venv
Expand Down Expand Up @@ -189,7 +189,7 @@ jobs:
if: startsWith(github.ref, 'refs/tags/')
needs: [linux-x86_64, windows, macos, sdist]
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- uses: actions/download-artifact@v8
with:
path: rust/kcl-python-bindings
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/kcl-wasm-lib-build-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
name: kcl-wasm-lib-build-and-publish
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1

- uses: actions/setup-node@v6.4.0
with:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/nix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ jobs:
nix-flake-check:
runs-on: namespace-profile-ubuntu-2-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
with:
submodules: recursive

- uses: cachix/install-nix-action@v31.10.7
- uses: cachix/install-nix-action@v31.11.0
with:
nix_path: nixpkgs=channel:nixos-unstable

Expand All @@ -28,11 +28,11 @@ jobs:
nix-build-linux:
runs-on: namespace-profile-ubuntu-8-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
with:
submodules: recursive

- uses: cachix/install-nix-action@v31.10.7
- uses: cachix/install-nix-action@v31.11.0
with:
nix_path: nixpkgs=channel:nixos-unstable

Expand All @@ -42,11 +42,11 @@ jobs:
nix-build-macos:
runs-on: namespace-profile-macos-6-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
with:
submodules: recursive

- uses: cachix/install-nix-action@v31.10.7
- uses: cachix/install-nix-action@v31.11.0
with:
nix_path: nixpkgs=channel:nixos-unstable

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
permissions:
contents: write
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1

- uses: actions/setup-node@v6.4.0
with:
Expand Down Expand Up @@ -118,7 +118,7 @@

- name: Upload release files to Github
if: ${{ github.event_name == 'release' }}
uses: softprops/action-gh-release@v3.0.1
uses: softprops/action-gh-release@v3.0.2

Check notice on line 121 in .github/workflows/publish-apps.yml

View workflow job for this annotation

GitHub Actions / zizmor

superfluous-actions

publish-apps.yml:121: action functionality is already included by the runner: use `gh release` in a script step
with:
files: 'out/Zoo*'

Expand All @@ -134,7 +134,7 @@
runs-on: namespace-profile-ubuntu-2-cores
steps:
- name: Check out code
uses: actions/checkout@v7.0.0
uses: actions/checkout@v7.0.1

- name: Set up Python
uses: actions/setup-python@v6.3.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ruff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
ruff:
runs-on: namespace-profile-ubuntu-2-cores
steps:
- uses: actions/checkout@v7.0.0
- uses: actions/checkout@v7.0.1
- uses: astral-sh/ruff-action@v4.1.0
with:
version: 0.15.22
Loading
Loading